fix: Update visibility check for position: fixed combined with pointer-events: none
#8095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
panzarino
changed the title
position: fixed combined with pointer-events: none
jennifer-shehane
requested changes
Jul 28, 2020
|
|
||
| this.$parentPointerEventsNone = add(`\ | ||
| <div style="pointer-events: none;"> | ||
| <span style="position: fixed; top: 20px;">parent pointer-events: none</span> |
There was a problem hiding this comment.
Can't tell this HTML from the HTML below it on the page since it's the same content.
Suggested change
| <span style="position: fixed; top: 20px;">parent pointer-events: none</span> | |
| <span style="position: fixed; top: 20px;">parent pointer-events: none; top: 20px</span> |
There was a problem hiding this comment.
Should be updated now with the self-contained covering element.
jennifer-shehane
approved these changes
Jul 29, 2020
|
Ignoring percy visual change as it is a timing issue - the collapsible is not fully opened, so that'll need to be addressed elsewhere. |
This was referenced Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
position: fixedelements having parent withpointer-events: nonemistakenly display as not visible / covered by another el #6675User facing changelog
Fixes a bug where
position: fixedcombined withpointer-events: nonecan cause an element to be reported as hidden when it is actually visibleAdditional details
document.elementFromPointignores elements that havepointer-events: none, and gets the element underneath instead. Previously, we would just check that that element was the same element or a descendant of the one we were trying to check. This adds another check if the element is a parent, which covers the case that the click fell through (and due to the other checks beforehand, does not accidentally misreport a hidden element as visible).PR Tasks
cypress-documentation?type definitions?cypress.schema.json?