Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rm electron-27 branch from publish binary script #28951

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

cacieprins
Copy link
Contributor

  • Closes

Additional details

The Electron 27 upgrade process required a specific branch target in the publish binary pipeline. This removes it, and should be merged after the open PR in that repository is merged.

Steps to test

How has the user experience changed?

PR Tasks

@cacieprins cacieprins marked this pull request as ready for review February 15, 2024 15:36
Copy link

cypress bot commented Feb 15, 2024

8 flaky tests on run #54048 ↗︎

0 28947 1341 0 Flakiness 8

Details:

Merge branch 'develop' into cacie/chore/rm-publish-binary-branch
Project: cypress Commit: a943184f88
Status: Passed Duration: 20:09 💡
Started: Feb 15, 2024 6:04 PM Ended: Feb 15, 2024 6:24 PM
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Screenshots
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
network stubbing > waiting and aliasing > yields the expected interception when two requests are raced Test Replay
Flakiness  commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
... > timeouts > sets custom responseTimeout Test Replay
Flakiness  e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
... > throws when foo cannot resolve Test Replay
Flakiness  commands/files.cy.js • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
... > throws a specific error when file exists when it shouldn't Test Replay

The first 5 flaky specs are shown, see all 8 specs in Cypress Cloud.

Review all test suite changes for PR #28951 ↗︎

@cacieprins cacieprins merged commit 2251f2d into develop Feb 15, 2024
80 of 82 checks passed
@cacieprins cacieprins deleted the cacie/chore/rm-publish-binary-branch branch February 15, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants