chore: remove pkg/driver //@ts-nocheck final #20169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
sainthkh
force-pushed
the
remove-ts-nocheck-final
branch
4 times, most recently
from
41f282d
to
339c30b
Compare
sainthkh
requested review from
jennifer-shehane
and removed request for
a team
flotwig
previously approved these changes
Feb 23, 2022
|
|
||
| addToLogs(log) | ||
| export default { |
There was a problem hiding this comment.
nit: it would be cool to get rid of export default { function1, function2 } and use export function1; export function2 where possible
There was a problem hiding this comment.
I didn't change it because we're currently importing them as import $Log from './log'. I guess this can be fixed after refactoring log to class.
ryanthemanuel
previously approved these changes
Feb 23, 2022
| @@ -449,7 +459,7 @@ const overrideRunnerHook = (Cypress, _runner, getTestById, getTest, setTest, get | |||
|
|
|||
| const getTestResults = (tests) => { | |||
| return _.map(tests, (test) => { | |||
| const obj = _.pick(test, 'id', 'duration', 'state') | |||
| const obj: any = _.pick(test, 'id', 'duration', 'state') | |||
There was a problem hiding this comment.
Can this be Record<string, any>?
There was a problem hiding this comment.
I changed it that way.
packages/driver/src/cypress.ts
Outdated
| @@ -75,7 +187,7 @@ class $Cypress { | |||
| this.setConfig(config) | |||
| } | |||
|
|
|||
| setConfig (config = {}) { | |||
| setConfig (config: any = {}) { | |||
There was a problem hiding this comment.
Can this be Record<string, any>?
There was a problem hiding this comment.
I changed it that way.
packages/driver/src/cypress/log.ts
Outdated
| @@ -86,7 +84,7 @@ const getSnapshotProps = (attrs) => { | |||
| return _.pick(attrs, SNAPSHOT_PROPS) | |||
| } | |||
|
|
|||
| const countLogsByTests = function (tests = {}) { | |||
| const countLogsByTests = function (tests: any = {}) { | |||
There was a problem hiding this comment.
Can this be Record<string, any>?
There was a problem hiding this comment.
I changed it that way.
sainthkh
force-pushed
the
remove-ts-nocheck-final
branch
from
24d9069
to
dc92a73
Compare
ryanthemanuel
approved these changes
Feb 25, 2022
flotwig
approved these changes
Feb 25, 2022
tgriesser
added a commit
that referenced
this pull request
Mar 2, 2022
* 10.0-release: fix: comment link to accurate docs (#20437) fix: scaffold commands file (#20398) fix(launchpad): support default export (#20383) feat(launchpad): support for Vue CLI 5 (#20413) fix: UNIFY-676 browsers should be configurable in setupNodeEvents (#20367) fix: make launchpad link open default browser (#20399) fix(icons): publish the files in the package fix: build icons in build-prod (#20411) test: migrate module-api to 10.0 chore: build this branch test: migrate module_api to system tests (#20265) chore: remove pkg/driver //@ts-nocheck final (#20169) chore: fix "cannot find module" in clone-repo-and-checkout-release-branch (#20293) chore: Update Chrome (beta) to 99.0.4844.45 (#20234) chore: fix CI cache state for darwin (#20339) Add TODO comments feedback chore: move tests to its own file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createinto class$Cy#18715User facing changelog
N/A. It's just removing
// @ts-nocheckcomments and defining types to avoid type errors.Additional details
How has the user experience changed?
N/A
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?