Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): update dependency electron to v15 🌟 #18317

Merged
merged 43 commits into from
Nov 9, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 30, 2021

BREAKING CHANGE: Updates Node major version from 14 to 16. No other breakage.

User-facing changelog

Upgraded Electron to 15.2.0. Bumps bundled Node to 16.5.0 and Chromium to 94.0.4606.71


Notes:

@renovate renovate bot requested a review from a team as a code owner September 30, 2021 19:44
@renovate renovate bot requested review from flotwig and chrisbreiding and removed request for a team September 30, 2021 19:44
@renovate renovate bot added renovate Triggered by renovatebot type: dependencies labels Sep 30, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 30, 2021

See the guidelines for reviewing dependency updates for info on how to review dependency update PRs.

@flotwig flotwig changed the base branch from develop to 9.0-release September 30, 2021 19:56
@flotwig flotwig marked this pull request as draft September 30, 2021 19:56
@cypress
Copy link

cypress bot commented Sep 30, 2021



Test summary

4229 4 50 2Flakiness 0


Run details

Project cypress
Status Failed
Commit 0d98e75
Started Nov 9, 2021 7:36 PM
Ended Nov 9, 2021 7:47 PM
Duration 11:04 💡
OS Linux Debian - 10.10
Browser Electron 94

View run in Cypress Dashboard ➡️


Failures

navigation_spec.js Failed
1 ... > throws on: 'Infinity'
2 ... > displays body_circular when body is circular
net_stubbing_spec.ts Failed
1 network stubbing > intercepting request > should delay the same amount on every response
2 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@renovate renovate bot force-pushed the renovate/electron-15.x branch 2 times, most recently from 35fc07b to f786f9a Compare September 30, 2021 20:21
@flotwig flotwig mentioned this pull request Oct 15, 2021
7 tasks
davidmunechika and others added 6 commits November 8, 2021 12:59
@flotwig flotwig marked this pull request as ready for review November 9, 2021 13:30
@flotwig flotwig changed the title chore(deps): update dependency electron to v15 🌟 feat(deps): update dependency electron to v15 🌟 Nov 9, 2021
Copy link
Contributor

@chrisbreiding chrisbreiding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, outside of all the failing tests 😅

@flotwig flotwig merged commit 3095d73 into 9.0-release Nov 9, 2021
@flotwig flotwig deleted the renovate/electron-15.x branch November 9, 2021 20:52
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 10, 2021

Released in 9.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
renovate Triggered by renovatebot type: dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants