Run specs with name containing '+' (#8015)

Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
cypress-io · Jul 23, 2020 · a1c562f · a1c562f · cypress-bot · Jul 23, 2020
1 parent e05b4cf
commit a1c562f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/server/lib/util/escape_filename.ts b/packages/server/lib/util/escape_filename.ts
@@ -1,11 +1,13 @@
 const ampersandRe = /&/g
 const percentRe = /%/g
 const questionRe = /\?/g
+const plusRe = /\+/g
 
 export function escapeFilenameInUrl (url: string) {
   // escape valid file name characters that cannot be used in URL
   return url
   .replace(percentRe, '%25') // %
   .replace(ampersandRe, '%26') // &
   .replace(questionRe, '%3F') // ? -> it's only valid in Linux
+  .replace(plusRe, '%2B') // + https://github.com/cypress-io/cypress/issues/5909
 }
diff --git a/packages/server/test/e2e/4_controllers_spec.js b/packages/server/test/e2e/4_controllers_spec.js
@@ -20,8 +20,8 @@ describe('e2e plugins', () => {
     })
   })
 
-  it('handles specs with $, &, ? in file name', function () {
-    let relativeSpecPath = path.join('d?ir&1%', '%di?r2&', 's%pec&?.js')
+  it('handles specs with $, &, ?, + in file name', function () {
+    let relativeSpecPath = path.join('d?ir&1%', '%di?r2&', 's%p+ec&?.js')
 
     // windows doesn't support ? in file names
     if (process.platform === 'win32') {