fix: empty state urls in navigation (#20948)

cypress-io · Apr 8, 2022 · 95feb15 · 95feb15 · cypress-bot · Apr 8, 2022
1 parent d5c033f
commit 95feb15
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/packages/driver/cypress/integration/cy/navigation_spec.js b/packages/driver/cypress/integration/cy/navigation_spec.js
@@ -146,6 +146,28 @@ describe('cy/navigation', () => {
       expect(triggeredHashChange).to.be.false
     })
 
+    it('when no urls or urlPosition in state', () => {
+      const state = $SetterGetter.create({
+        navHistoryDelta: 1,
+      })
+
+      const triggeredHashChange = historyNavigationTriggeredHashChange(state)
+
+      expect(triggeredHashChange).to.be.false
+    })
+
+    it('when no urlPosition in state', () => {
+      const state = $SetterGetter.create({
+        navHistoryDelta: 1,
+        url: 'https://my_url.com/',
+        urls: ['https://my_url.com/', 'https://my_url.com/home'],
+      })
+
+      const triggeredHashChange = historyNavigationTriggeredHashChange(state)
+
+      expect(triggeredHashChange).to.be.false
+    })
+
     it('when neither url has a hash', () => {
       const state = $SetterGetter.create({
         navHistoryDelta: 1,

diff --git a/packages/driver/src/cy/navigation.ts b/packages/driver/src/cy/navigation.ts
@@ -1,3 +1,4 @@
+import _ from 'lodash'
 import { $Location } from '../cypress/location'
 
 export const bothUrlsMatchAndOneHasHash = (current, remote, eitherShouldHaveHash: boolean = false): boolean => {
@@ -26,6 +27,11 @@ export const historyNavigationTriggeredHashChange = (state): boolean => {
 
   const urls = state('urls')
   const urlPosition = state('urlPosition')
+
+  if (_.isEmpty(urls) || urlPosition === undefined) {
+    return false
+  }
+
   const currentUrl = $Location.create(urls[urlPosition])
 
   const nextPosition = urlPosition + delta