Fix types.

cypress-io · Nov 8, 2021 · 07b7cb3 · 07b7cb3
1 parent 7c5a5f8
commit 07b7cb3
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 11 deletions.
diff --git a/packages/driver/src/cy/assertions.ts b/packages/driver/src/cy/assertions.ts
@@ -1,3 +1,5 @@
+// @ts-nocheck
+
 import _ from 'lodash'
 import Promise from 'bluebird'
 
@@ -48,6 +50,8 @@ const isDomSubjectAndMatchesValue = (value, subject) => {
     // and that all the els are the same
     return isDomTypeFn(subject) && allElsAreTheSame()
   }
+
+  return false
 }
 
 // Rules:

diff --git a/packages/driver/src/cy/commands/window.ts b/packages/driver/src/cy/commands/window.ts
@@ -246,16 +246,18 @@ export default (Commands, Cypress, cy, state) => {
       if (_.isString(presetOrWidth) && _.isBlank(presetOrWidth)) {
         $errUtils.throwErrByPath('viewport.empty_string', { onFail: options._log })
       } else if (_.isString(presetOrWidth)) {
-        const getPresetDimensions = (preset) => {
+        const getPresetDimensions = (preset): number[] => {
           try {
             return _.map(viewports[presetOrWidth].split('x'), Number)
           } catch (e) {
             const presets = _.keys(viewports).join(', ')
 
-            return $errUtils.throwErrByPath('viewport.missing_preset', {
+            $errUtils.throwErrByPath('viewport.missing_preset', {
               onFail: options._log,
               args: { preset, presets },
             })
+
+            return [] // dummy code to silence TS
           }
         }
 

diff --git a/packages/driver/src/cy/net-stubbing/add-command.ts b/packages/driver/src/cy/net-stubbing/add-command.ts
@@ -199,7 +199,7 @@ export function addCommand (Commands, Cypress: Cypress.Cypress, cy: Cypress.cy,
       staticResponse = handler as StaticResponse
     } else if (!_.isUndefined(handler)) {
       // a handler was passed but we dunno what it's supposed to be
-      return $errUtils.throwErrByPath('net_stubbing.intercept.invalid_handler', { args: { handler } })
+      $errUtils.throwErrByPath('net_stubbing.intercept.invalid_handler', { args: { handler } })
     }
 
     const routeMatcher = annotateMatcherOptionsTypes(matcher)
@@ -211,7 +211,7 @@ export function addCommand (Commands, Cypress: Cypress.Cypress, cy: Cypress.cy,
     }
 
     if (routeMatcher.middleware && !hasInterceptor) {
-      return $errUtils.throwErrByPath('net_stubbing.intercept.invalid_middleware_handler', { args: { handler } })
+      $errUtils.throwErrByPath('net_stubbing.intercept.invalid_middleware_handler', { args: { handler } })
     }
 
     const frame: NetEvent.ToServer.AddRoute<BackendStaticResponseWithArrayBuffer> = {
@@ -257,11 +257,11 @@ export function addCommand (Commands, Cypress: Cypress.Cypress, cy: Cypress.cy,
         // url, mergeRouteMatcher, handler
         // @ts-ignore
         if (handler.url) {
-          return $errUtils.throwErrByPath('net_stubbing.intercept.no_duplicate_url')
+          $errUtils.throwErrByPath('net_stubbing.intercept.no_duplicate_url')
         }
 
         if (!arg2) {
-          return $errUtils.throwErrByPath('net_stubbing.intercept.handler_required')
+          $errUtils.throwErrByPath('net_stubbing.intercept.handler_required')
         }
 
         checkExtraArguments(['url', 'mergeRouteMatcher', 'handler'])

diff --git a/packages/driver/src/cy/net-stubbing/events/before-request.ts b/packages/driver/src/cy/net-stubbing/events/before-request.ts
@@ -167,7 +167,7 @@ export const onBeforeRequest: HandlerFn<CyHttpMessages.IncomingRequest> = (Cypre
     },
     on (eventName, handler) {
       if (!validEvents.includes(eventName)) {
-        return $errUtils.throwErrByPath('net_stubbing.request_handling.unknown_event', {
+        $errUtils.throwErrByPath('net_stubbing.request_handling.unknown_event', {
           args: {
             validEvents,
             eventName,
@@ -176,7 +176,7 @@ export const onBeforeRequest: HandlerFn<CyHttpMessages.IncomingRequest> = (Cypre
       }
 
       if (!_.isFunction(handler)) {
-        return $errUtils.throwErrByPath('net_stubbing.request_handling.event_needs_handler')
+        $errUtils.throwErrByPath('net_stubbing.request_handling.event_needs_handler')
       }
 
       subscribe(eventName, handler)

diff --git a/packages/driver/src/cy/video-recorder.ts b/packages/driver/src/cy/video-recorder.ts
@@ -24,6 +24,8 @@ export const initVideoRecorder = (Cypress) => {
         mimeType: 'video/webm',
       }
 
+      // TODO: update TypeScript to 4.4+.
+      // @ts-ignore
       const mediaRecorder = new window.MediaRecorder(stream, options)
 
       mediaRecorder.start(200)

diff --git a/packages/driver/src/cypress/cy.ts b/packages/driver/src/cypress/cy.ts
@@ -1,3 +1,5 @@
+// @ts-nocheck
+
 /* eslint-disable prefer-rest-params */
 import _ from 'lodash'
 import Promise from 'bluebird'
@@ -195,9 +197,6 @@ class $Cy implements ITimeouts, IStability, IAssertions, IRetries, IJQuery, ILoc
   interceptFocus: ReturnType<typeof createFocused>['interceptFocus']
   interceptBlur: ReturnType<typeof createFocused>['interceptBlur']
 
-  // temporary -> should be removed
-  focused: any
-
   constructor (specWindow, Cypress, Cookies, state, config) {
     this.id = _.uniqueId('cy')
     this.state = state