Update Docker Image, .node-version to use Node 12.18.0, fix additional flake #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 15, 2020 17:07
kevinold
changed the title
kevinold
changed the title
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
added 6 commits
June 16, 2020 08:46
Codecov Report
@@ Coverage Diff @@
## develop #428 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 79 79
Lines 1441 1441
Branches 234 234
=========================================
Hits 1441 1441 Continue to review full report at Codecov.
|
kevinold
changed the title
bahmutov
reviewed
Jun 16, 2020
| @@ -86,7 +86,11 @@ describe("Notifications", function () { | |||
| cy.visit(`/transaction/${transaction.id}`); | |||
| }); | |||
|
|
|||
| const likesCountSelector = "[data-test*=transaction-like-count]"; | |||
There was a problem hiding this comment.
I think this happens several times in this spec file, might as well factor out in a small utility function
obaidaattaee
pushed a commit
to obaidaattaee/cypress-realworld-app
that referenced
this pull request
Nov 30, 2021
…l flake (cypress-io#428) * update docker image * update node version to 12.18 * wait for comment to be posted * set firefoxGcInterval to null per cypress-io/cypress#6813 * remove quotes from cypress config * add assertion to fix additional flake * set firefoxGcInterval to null in cypress.json vs circle config * ensure like button click is registered on server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.