Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build/upgrade mui v4 to v5 #1522

Merged
merged 51 commits into from
Aug 27, 2024
Merged

Build/upgrade mui v4 to v5 #1522

merged 51 commits into from
Aug 27, 2024

Commits on Mar 5, 2024

  1. build: yarn add @mui/material @mui/styles ; yarn add @mui/lab ; yarn … 

    …add @mui/icons-material
    @timheilman
    timheilman committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    38905ef View commit details
    Browse the repository at this point in the history

  2. build: yarn add @emotion/react @emotion/styled

    @timheilman
    timheilman committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    852d25d View commit details
    Browse the repository at this point in the history

  3. build: npx @mui/codemod@latest v5.0.0/preset-safe src

    @timheilman
    timheilman committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    552005b View commit details
    Browse the repository at this point in the history

  4. build: empty commit, for: npx @mui/codemod@latest v5.0.0/variant-prop… 

    … src
    @timheilman
    timheilman committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    885352d View commit details
    Browse the repository at this point in the history

  5. build: npx @mui/codemod@latest v5.0.0/link-underline-hover src

    @timheilman
    timheilman committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    05c230b View commit details
    Browse the repository at this point in the history

  6. build: npx prettier --write src backend cypress scripts

    @timheilman
    timheilman committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    4a5cb7b View commit details
    Browse the repository at this point in the history

  7. build: yarn remove @material-ui/core @material-ui/icons @material-ui/lab

    @timheilman
    timheilman committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    3003c65 View commit details
    Browse the repository at this point in the history

  8. build: rm patches/@material-ui+core+4.12.4.patch

    @timheilman
    timheilman committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    dce9fb2 View commit details
    Browse the repository at this point in the history

  9. build: update renovate.json to use @mui not @material-ui

    @timheilman
    timheilman committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    5f859b5 View commit details
    Browse the repository at this point in the history

  10. build: update ThemeProvider import, per 

    https://mui.com/material-ui/migration/v5-style-changes/\#update-themeprovider-import
    @timheilman
    timheilman committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    76941ab View commit details
    Browse the repository at this point in the history

  11. build: update EventType for Tabs onChange event, per 

    https://mui.com/material-ui/migration/v5-component-changes/\#update-event-type-typescript-5
    @timheilman
    timheilman committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    84b79d2 View commit details
    Browse the repository at this point in the history

  12. fix: Two tabs problems: 

    First, the color changes indicated at https://mui.com/material-ui/migration/v5-component-changes/#update-default-indicatorcolor-and-textcolor-prop-values

Second, remove the the trailing "px" a number rather than string when passing values to the react-virtualized List component.  See
https://mui.com/material-ui/migration/v5-style-changes/\#%E2%9C%85-remove-px-suffix
    @timheilman
    timheilman committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    622f88e View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. fix: transaction amount was falling off right edge

    @timheilman
    timheilman committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    17b7ab2 View commit details
    Browse the repository at this point in the history

  2. fix: indirection of onChange prop of Slider via ownerState 

    this was causing the slider-based cypress tests to fail.
    @timheilman
    timheilman committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    5909365 View commit details
    Browse the repository at this point in the history

  3. fix: remove zIndex from AppBar to fix drawer issue 

    appBar was still over the date picker in mobile screen size, failing one of the cypress:run:mobile tests.  See also
https://mui.com/material-ui/migration/v5-component-changes/\#fix-z-index-issues
    @timheilman
    timheilman committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    ea9a4a6 View commit details
    Browse the repository at this point in the history

  4. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/containers 

    followed by lint fixes and manual review
    @timheilman
    timheilman committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    87d2c83 View commit details
    Browse the repository at this point in the history

  5. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Ba… 

    …nkAccountForm.tsx

linting and review
    @timheilman
    timheilman committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    ae8dba8 View commit details
    Browse the repository at this point in the history

  6. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Co… 

    …mmentForm.tsx

review, lint
    @timheilman
    timheilman committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    f6c29f3 View commit details
    Browse the repository at this point in the history

  7. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Ma… 

    …inLayout.tsx

review, remove class for root and use ampersand instead, adding a flexGrow:1 to get styling as before
    @timheilman
    timheilman committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    d4983cb View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Na… 

    …vBar.tsx,

review, appBarShift was incorrectly considered a child of root; fixed that with removal of space between & and ., lint
    @timheilman
    timheilman committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    3990f9d View commit details
    Browse the repository at this point in the history

  2. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Na… 

    …vDrawer.tsx

review, lint, no issues
    @timheilman
    timheilman committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    ba97456 View commit details
    Browse the repository at this point in the history

  3. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/No… 

    …tificationListItem.tsx

review, lint, no issues
    @timheilman
    timheilman committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    53b69c5 View commit details
    Browse the repository at this point in the history

  4. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Si… 

    …gnInForm.tsx

lint, cast StyledContainer to typeof Container per https://github.com/mui/material-ui/issues/15695\#ref-commit-7fd1a29
    @timheilman
    timheilman committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    b9a736b View commit details
    Browse the repository at this point in the history

  5. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Si… 

    …gnUpForm.tsx

lint, cast StyledContainer to typeof Container per https://github.com/mui/material-ui/issues/15695\#ref-commit-7fd1a29
    @timheilman
    timheilman committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    8887694 View commit details
    Browse the repository at this point in the history

  6. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Sk… 

    …eletonList.tsx

lint, review, no issues
    @timheilman
    timheilman committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    ebe6f1a View commit details
    Browse the repository at this point in the history

  7. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr… 

    …ansactionAmount.tsx

lint, remove space between & and . because classes are conditionally applied
    @timheilman
    timheilman committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    b213b91 View commit details
    Browse the repository at this point in the history

  8. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr… 

    …ansactionCreateStepOne.tsx

lint and review, no issues
    @timheilman
    timheilman committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    7f9595c View commit details
    Browse the repository at this point in the history

  9. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr… 

    …ansactionCreateStepTwo.tsx

lint, review, no issues
    @timheilman
    timheilman committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    7e0ba7e View commit details
    Browse the repository at this point in the history

  10. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr… 

    …ansactionCreateStepThree.tsx

lint, review, no issues
    @timheilman
    timheilman committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e5498e0 View commit details
    Browse the repository at this point in the history

  11. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr… 

    …ansactionDateRangeFilter.tsx

lint, review, no issues
    @timheilman
    timheilman committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    b6c0ab6 View commit details
    Browse the repository at this point in the history

  12. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr… 

    …ansactionDetail.tsx

lint, review, no issues
    @timheilman
    timheilman committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    87feb2d View commit details
    Browse the repository at this point in the history

  13. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr… 

    …ansactionItem.tsx

lint, review, problems with SmallAvatar, fixed manually
    @timheilman
    timheilman committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    9925dca View commit details
    Browse the repository at this point in the history

  14. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr… 

    …ansactionList.tsx

lint, review, no issues
    @timheilman
    timheilman committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    9509c70 View commit details
    Browse the repository at this point in the history

  15. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr… 

    …ansactionListAmountRangeFilter.tsx

lint, review, did not work really at all, fixed by using sx prop rather than classes at all
    @timheilman
    timheilman committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e322576 View commit details
    Browse the repository at this point in the history

  16. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr… 

    …ansactionListFilters.tsx

lint, review, no issues
    @timheilman
    timheilman committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    f836550 View commit details
    Browse the repository at this point in the history

  17. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Tr… 

    …ansactionTitle.tsx

lint, review, no issues
    @timheilman
    timheilman committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    459dc56 View commit details
    Browse the repository at this point in the history

  18. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components/Us… 

    …erSettingsForm.tsx

lint, review, form did not want to play nice with classes, fixed with sx for submit button and styled wrapping div for form
    @timheilman
    timheilman committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    11a6417 View commit details
    Browse the repository at this point in the history

  19. build: npx @mui/codemod@latest v5.0.0/jss-to-styled src/components 

    had apparently accidentally failed-to-checkin TransactionInfiniteList and userSearchForm, but both were reviewed and had no issues
    @timheilman
    timheilman committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    7d16340 View commit details
    Browse the repository at this point in the history

  20. build: yarn remove @mui/styles and some 

    minor style fixups to be rid of the dependency causing the peer dependency warning
    @timheilman
    timheilman committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    756a0f4 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. fix: oops did not mean to modify database.json

    @timheilman
    timheilman committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    c18c08a View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Merge branch 'develop' into build/upgrade-mui-v4-to-v5

    @timheilman
    timheilman committed May 16, 2024
    Configuration menu
    Copy the full SHA
    c009da8 View commit details
    Browse the repository at this point in the history

  2. build: remove @ts-expect-error annotations no longer used after yarn.… 

    …lock

merge resolution
    @timheilman
    timheilman committed May 16, 2024
    Configuration menu
    Copy the full SHA
    a237f2c View commit details
    Browse the repository at this point in the history

  3. test: issue 1278 re-enabling test that had failed on firefox, 

    which is not failing after the upgrade to MUI v5.  See
cypress-io#1278
    @timheilman
    timheilman committed May 16, 2024
    Configuration menu
    Copy the full SHA
    3a20270 View commit details
    Browse the repository at this point in the history

  4. style: npm run prettier

    @timheilman
    timheilman committed May 16, 2024
    Configuration menu
    Copy the full SHA
    6e2e96b View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2024

  1. Merge remote-tracking branch 'origin/develop' into build/upgrade-mui-… 

    …v4-to-v5
    @timheilman
    timheilman committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    0064916 View commit details
    Browse the repository at this point in the history

  2. fix: unset flex-direction which is newly set to row-reverse for 

    AvatarGroup in mui5.
    @timheilman
    timheilman committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    2879b64 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. fix: undo parent commit fix because avatars were backward and 

    no longer overlapping.  Instead eat up space to right of avatars.
    @timheilman
    timheilman committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    c01fddf View commit details
    Browse the repository at this point in the history

  2. fix: get body font size back down to 14, establish knobs for 

    modifying input styles
    @timheilman
    timheilman committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    cd6c00b View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. Merge remote-tracking branch 'origin/develop' into build/upgrade-mui-… 

    …v4-to-v5
    @timheilman
    timheilman committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    8c67acb View commit details
    Browse the repository at this point in the history

  2. test: apply force:true to clicks failing due to issue #29776

    @timheilman
    timheilman committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    64224dd View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Merge branch 'develop' of github.com:cypress-io/cypress-realworld-app… 

    … into mui5
    @AtofStryker
    AtofStryker committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    5fcfe43 View commit details
    Browse the repository at this point in the history