Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: BS5 for greater readability #1067

Merged
merged 2 commits into from
Jun 13, 2022
Merged

docs: BS5 for greater readability #1067

merged 2 commits into from
Jun 13, 2022

Conversation

maelle
Copy link
Member

@maelle maelle commented Jun 13, 2022

  • bigger font
  • search

IMHO #1064 should come after cynkratemplate itself uses BS5 and therefore has a search bar.

image

@maelle
Copy link
Member Author

maelle commented Jun 13, 2022

The navbar links should not be blue, fix would be r-lib/webfakes@7aeb062, will do in a sec

@maelle maelle marked this pull request as draft June 13, 2022 10:05
@maelle maelle marked this pull request as ready for review June 13, 2022 10:14
@maelle
Copy link
Member Author

maelle commented Jun 13, 2022

I've been happily reading the docs in a local build with this config.

@maelle maelle requested a review from krlmlr June 13, 2022 11:23
@krlmlr
Copy link
Collaborator

krlmlr commented Jun 13, 2022

Thanks. https://github.com/cynkra/dm/actions/runs/2488843602 will put it into https://cynkra.github.io/dm/dev/ in a few minutes (because the branch name is prefixed with docs-), I'll take a look.

@krlmlr krlmlr merged commit b0eb211 into main Jun 13, 2022
@krlmlr krlmlr deleted the bs5 branch June 13, 2022 16:54
@krlmlr
Copy link
Collaborator

krlmlr commented Jun 13, 2022

Thanks, I like it! Where does the logo come from?

image

How can we make the logos (cynkra, energie360°, ...) look good in dark mode?

@krlmlr krlmlr mentioned this pull request Jun 13, 2022
@maelle
Copy link
Member Author

maelle commented Jun 21, 2022

@krlmlr the logo comes from https://github.com/cynkra/dm/blob/main/man/figures/logo.png which is a location automatically recognized by pkgdown. 😸

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants