Recompute runahead limit after cylc remove
#5192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
reviewed
Oct 13, 2022
wxtim
approved these changes
Oct 13, 2022
Comment on lines
+563
to
+578
| async def test_runahead_after_remove( | ||
| example_flow: Scheduler | ||
| ) -> None: | ||
| """The runahead limit should be recomputed after tasks are removed. | ||
|
|
||
| """ | ||
| task_pool = example_flow.pool | ||
| assert int(task_pool.runahead_limit_point) == 4 | ||
|
|
||
| # No change after removing an intermediate cycle. | ||
| task_pool.remove_tasks(['3/*']) | ||
| assert int(task_pool.runahead_limit_point) == 4 | ||
|
|
||
| # Should update after removing the first point. | ||
| task_pool.remove_tasks(['1/*']) | ||
| assert int(task_pool.runahead_limit_point) == 5 |
oliver-sanders
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a trivial fix, but diagnosing the problem was complicated by #5186
With the example of #5185, on this branch:
Run till stalled with 1,2,3,4,5/b failed.
cylc remove bug//1/b:failedremoves1/b, and the scheduler releases6/bfrom runahead 👍cylc remove bug//*/b:failedremoves all failedb, and the scheduler releases the next 5 cycles from runahead 👍cylc remove bug//*/*:failedstill causes a shutdown, because the scheduler erroneously removes6/b:waitingvia bug Task ID filtering broken #5186 👎 ... fixed by id: preserve selectors for "task" and "workflow" properties #5188 👍 )Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.CHANGES.mdentry included if this is a change that can affect users