Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #283

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Update dependencies #283

merged 2 commits into from
Jul 17, 2024

Conversation

zeroalphat
Copy link
Contributor

No description provided.

Signed-off-by: zeroalphat <taichi-takemura@cybozu.co.jp>
Copy link
Contributor

@YZ775 YZ775 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update etcd version in Makefile?
https://github.com/cybozu-go/sabakan/blob/main/Makefile

I think it would be better to set same version in cybozu-go/neco

Signed-off-by: zeroalphat <taichi-takemura@cybozu.co.jp>
@zeroalphat zeroalphat requested a review from YZ775 July 17, 2024 08:37
Copy link
Contributor

@YZ775 YZ775 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeroalphat zeroalphat merged commit c6b6904 into main Jul 17, 2024
5 checks passed
@zeroalphat zeroalphat deleted the update-dependency branch July 17, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants