enbable TLS for crypts APIs #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YZ775
force-pushed
the
enable-tls
branch
3 times, most recently
from
d1820cb
to
ec5203b
Compare
YZ775
force-pushed
the
enable-tls
branch
5 times, most recently
from
92ec553
to
b079c8a
Compare
masa213f
requested changes
Oct 16, 2023
masa213f
requested changes
Oct 19, 2023
YZ775
force-pushed
the
enable-tls
branch
4 times, most recently
from
7e3a9ad
to
3489253
Compare
Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp> add advertise-url-https Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp> sabakan url Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp> remove http crypts API endpoint Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp> skip booting sabakan server when certs not exist Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp> fix test Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp> update sabactl Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp> fix actions Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp> fix ignition Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp> rename ca cert Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp> add advertise-url-https in test Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp> rename TLSEnabled Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp> add docs Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp>
Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp>
Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp>
Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp>
masa213f
requested changes
Oct 30, 2023
YZ775
force-pushed
the
enable-tls
branch
6 times, most recently
from
2b37d4f
to
98c5448
Compare
Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp>
Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp>
YZ775
force-pushed
the
enable-tls
branch
2 times, most recently
from
bcc5d09
to
06ac01f
Compare
Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp>
masa213f
requested changes
Nov 6, 2023
mtest/Makefile
Outdated
|
|
||
| CERTS = \ | ||
| $(OUTPUT)/certs/ca.crt \ | ||
| $(OUTPUT)/certs/server.crt\ |
There was a problem hiding this comment.
Suggested change
| $(OUTPUT)/certs/server.crt\ | |
| $(OUTPUT)/certs/server.crt \ |
Makefile
Outdated
| E2E_OUTPUT=$(abspath ./e2e/output) | ||
| E2E_CERTS = \ | ||
| $(E2E_OUTPUT)/certs/ca.crt \ | ||
| $(E2E_OUTPUT)/certs/server.crt\ |
There was a problem hiding this comment.
Suggested change
| $(E2E_OUTPUT)/certs/server.crt\ | |
| $(E2E_OUTPUT)/certs/server.crt \ |
Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp>
Signed-off-by: YZ775 <yuzuki-mimura@cybozu.co.jp>
zoetrope
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YZ775 yuzuki-mimura@cybozu.co.jp