Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow some state transitions. #242

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Allow some state transitions. #242

merged 2 commits into from
Mar 22, 2022

Conversation

kmdkuk
Copy link
Contributor

@kmdkuk kmdkuk commented Mar 11, 2022 •
edited

Allow following state transitions.

  • Unhealthy --> Updating
  • Unreachable --> Updating
    • To restart Unhealthy, Unreachable equipment using Updating state.
  • Unreachable --> Unhealthy
    • If Unhealthy equipment temporarily becomes Unreachable, it will be stuck in the Unreachable state
  • Uninitialized --> Unhealthy
  • Uninitialized --> Unreachable
    • To prevent Unhealthy or Unreachable equipment from getting stuck in the Uninitialized state after a state transition from Updating to Uninitialized.
    • If this change is made, it could cause an immediate transition from Uninitialized to Unhealthy or Unreachable. This is temporary and I see no problem as it will be pulled back to the correct state by the external controller.

Signed-off-by: kouki kouworld0123@gmail.com

@kmdkuk kmdkuk self-assigned this Mar 11, 2022
@kmdkuk kmdkuk changed the title WIP Improve machine states Allow some state transitions. Mar 15, 2022
@kmdkuk
Allow some state transitions.
fb88442 
Signed-off-by: kouki <kouworld0123@gmail.com>
@kmdkuk kmdkuk marked this pull request as ready for review March 17, 2022 07:16
@kmdkuk
Undo transition strict from uninitialized to unhealthy or unreachable
9d22612 
Signed-off-by: kouki <kouworld0123@gmail.com>
morimoto-cybozu
morimoto-cybozu approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@morimoto-cybozu morimoto-cybozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morimoto-cybozu morimoto-cybozu merged commit 3ea6e2b into main Mar 22, 2022
@morimoto-cybozu morimoto-cybozu deleted the improve-machine-states branch March 22, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morimoto-cybozu morimoto-cybozu morimoto-cybozu approved these changes

@umezawatakeshi umezawatakeshi umezawatakeshi approved these changes

Assignees

@kmdkuk kmdkuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kmdkuk @morimoto-cybozu @umezawatakeshi