[sabakan] improve sabactl machines get #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamatcha
changed the title
yamatcha
force-pushed
the
improve-sabactl-machines-get
branch
from
29685f5
to
ee21c7c
Compare
Signed-off-by: yamatcha <soju-yamashita@cybozu.co.jp>
Signed-off-by: yamatcha <soju-yamashita@cybozu.co.jp>
yamatcha
changed the title
Signed-off-by: yamatcha <soju-yamashita@cybozu.co.jp>
|
Please add test cases. |
zoetrope
requested changes
Feb 16, 2022
| @@ -152,8 +153,10 @@ func (mi *machinesIndex) query(q sabakan.Query) []string { | |||
|
|
|||
| res := make(map[string]struct{}) | |||
|
|
|||
| for _, serial := range mi.Rack[q.Rack()] { | |||
| res[serial] = struct{}{} | |||
| for _, rack := range strings.Split(q.Rack(), ",") { | |||
There was a problem hiding this comment.
Why can we only specify multiple racks?
We want to specify other options as well.
The original issue is just an example of a rack.
models/etcd/machine.go
Outdated
| @@ -258,8 +258,9 @@ RETRY: | |||
| func (d *driver) machineQuery(ctx context.Context, q sabakan.Query) ([]*sabakan.Machine, error) { | |||
| var serials []string | |||
|
|
|||
| qRemovedWithout := q.RemoveWithout() | |||
There was a problem hiding this comment.
I could not read the intent of this code.
Does "without" mean the same as "empty"?
There was a problem hiding this comment.
I understood.
But I think this code is not readable.
Please rewrite this code or add a comment.
|
I checked for now! |
Signed-off-by: yamatcha <soju-yamashita@cybozu.co.jp>
Signed-off-by: yamatcha <soju-yamashita@cybozu.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yamatcha soju-yamashita@cybozu.co.jp