update for etcd 3.5.1 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: UMEZAWA Takeshi <takeshi-umezawa@cybozu.co.jp>
ymmt2005
reviewed
Dec 20, 2021
.github/workflows/main.yaml
Outdated
| @@ -21,7 +21,7 @@ jobs: | |||
| go-version: ${{ env.go-version }} | |||
|
|
|||
| - name: Start etcd container | |||
| run: docker run -d --network host quay.io/coreos/etcd:v3.4.16 | |||
| run: docker run -d --network host quay.io/coreos/etcd:v3.5.1 | |||
There was a problem hiding this comment.
There is a new repository since v3.2.5
gcr.io/etcd-development/etcd
ref. https://etcd.io/docs/v3.5/op-guide/container/#running-a-single-node-etcd-1
There was a problem hiding this comment.
https://github.com/etcd-io/etcd/releases/tag/v3.2.5
Starting from
v3.2.5, we are switching togcr.io/etcd-development/etcd.
quay.io/coreos/etcdwill be deprecated in the future.
Hmm...
They should emphasize their deprecation policy much more.
Signed-off-by: UMEZAWA Takeshi <takeshi-umezawa@cybozu.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: UMEZAWA Takeshi takeshi-umezawa@cybozu.co.jp