Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for etcd 3.4.16 #217

Merged
merged 2 commits into from
May 21, 2021
Merged

Update for etcd 3.4.16 #217

merged 2 commits into from
May 21, 2021

Conversation

yokaze
Copy link
Contributor

@yokaze yokaze commented May 18, 2021 •
edited

  • Update for etcd 3.4.16
    Use etcdutil v1.4.0.
    Import etcd 3.4.16 using corresponding commit hash.
    Import from "go.etcd.io".
    CI downloads etcd images from quay.io/coreos/etcd instead of quay.io/cybozu/etcd, because it removes unnecessary dependency.

  • Update packages
    Update imported packages except for the following ones:

    • github.com/coreos/ignition v0.35 -> v2.10.1 (I suspect some reason not to upgrade it)
    • go.universe.tf/netboot (No release is provided and the latest commit fails at its CI)

Signed-off-by: Daichi Sakaue daichi-sakaue@cybozu.co.jp

@yokaze yokaze self-assigned this May 18, 2021
@yokaze
Update for etcd 3.4.16
ee5d074 
Signed-off-by: Daichi Sakaue <daichi-sakaue@cybozu.co.jp>
@yokaze
Update packages
f290d12 
Signed-off-by: Daichi Sakaue <daichi-sakaue@cybozu.co.jp>
@yokaze yokaze marked this pull request as ready for review May 21, 2021 06:19
@yokaze yokaze requested review from ymmt2005 and zoetrope May 21, 2021 06:19
@ymmt2005
Copy link
Member

@yokaze
Could you upgrade netboot package in a separate PR?

ymmt2005
ymmt2005 approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yokaze yokaze merged commit ef0d560 into main May 21, 2021
@yokaze yokaze deleted the etcd-3.4 branch May 21, 2021 06:45
@morimoto-cybozu morimoto-cybozu mentioned this pull request May 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymmt2005 ymmt2005 ymmt2005 approved these changes

@zoetrope zoetrope Awaiting requested review from zoetrope

Assignees

@yokaze yokaze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yokaze @ymmt2005