Use staticcheck #201
Merged
Use staticcheck #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masa213f
force-pushed
the
refactor-mtest
branch
4 times, most recently
from
5a8f843
to
31b1f04
Compare
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
masa213f
force-pushed
the
refactor-mtest
branch
from
49b82c7
to
e1a14c7
Compare
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
masa213f
force-pushed
the
refactor-mtest
branch
from
e1a14c7
to
cec82ab
Compare
Signed-off-by: Yusuke Suzuki <yusuke-suzuki@cybozu.co.jp>
ymmt2005
requested changes
Nov 4, 2020
| @@ -19,21 +19,15 @@ import ( | |||
|
|
|||
| const ( | |||
| // ExitSuccess represents no error. | |||
| ExitSuccess subcommands.ExitStatus = subcommands.ExitSuccess | |||
There was a problem hiding this comment.
Please get rid of github.com/google/subcommands as it was replaced with cobra.
models/etcd/dhcp.go
Outdated
Comment on lines
70
to
72
| if l.hwMap == nil { | ||
| return json.Marshal(make(map[string]leaseInfo)) | ||
| } |
Co-authored-by: Yamamoto, Hirotaka <ymmt2005@gmail.com>
Signed-off-by: Yusuke Suzuki <yusuke-suzuki@cybozu.co.jp>
Signed-off-by: Yusuke Suzuki <yusuke-suzuki@cybozu.co.jp>
ysksuzuki
commented
Nov 4, 2020
models/etcd/dhcp.go
Outdated
| if l.hwMap == nil { | ||
| l.hwMap = make(map[string]leaseInfo) | ||
| } | ||
|
|
There was a problem hiding this comment.
In some cases, hwmap will be nil, so we initialize it here.
There was a problem hiding this comment.
Why do you want to initialize it here?
I think it can be initialized where a new key is stored in this map.
There was a problem hiding this comment.
I think it is better to allocate the map when initializing the "leaseUsage" structure.
In this case, in effect, this unmarshaller initializes the structure, so we're allocating the map here.
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the followings