Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Prometheus instrumentation #181

Merged
merged 16 commits into from
Jan 17, 2020
Merged

Add Prometheus instrumentation #181

merged 16 commits into from
Jan 17, 2020

Conversation

kfyharukz
Copy link
Contributor

@kfyharukz kfyharukz commented Jan 14, 2020 •
edited by dulltz

Add Prometheus metrics.

  • The machine status
  • The total size of images/assets
  • The count of images/assets
  • The API request count per verb and status code

@kfyharukz kfyharukz self-assigned this Jan 14, 2020
@kfyharukz kfyharukz changed the title [ci skip] Add document for metrics. Add instrumentation Jan 14, 2020
dulltz and others added 14 commits January 15, 2020 14:27
@dulltz
Implement machine_status metrics
d5b8c4c 
Copy from PoC

Signed-off-by: dulltz <isrgnoe@gmail.com>
@dulltz
[ci skip] add test for metrics
a46c72c
@kfyharukz
wip: Add metrics for assets & images.
2d3fc1f
@dulltz
Add unit test for GetInfoAll
c833b01
@dulltz
Fix to set default interval
ea0ee9d
@kfyharukz
Fix tests for metrics.
ff9b71d
@kfyharukz
Fix assets and images label.
38e91a6
@morimoto-cybozu
fix key name.
87dcb59 
Signed-off-by: morimoto-cybozu <kenji_morimoto@cybozu.co.jp>
@morimoto-cybozu
[ci skip] fix metrics updater test.
2d8adae 
Signed-off-by: morimoto-cybozu <kenji_morimoto@cybozu.co.jp>
@morimoto-cybozu
[ci skip] fix test to generate tar image correctly.
00457ec 
Signed-off-by: morimoto-cybozu <kenji_morimoto@cybozu.co.jp>
@binoue
metrics: implement image metrics
108ef8a
@morimoto-cybozu
Remove unnecessary label for metrics.
775d06f 
Signed-off-by: morimoto-cybozu <kenji_morimoto@cybozu.co.jp>
@morimoto-cybozu
Add metrics for API calls.
9635e39 
Signed-off-by: morimoto-cybozu <kenji_morimoto@cybozu.co.jp>
@morimoto-cybozu
add metrics tests.
a837c6e 
Signed-off-by: morimoto-cybozu <kenji_morimoto@cybozu.co.jp>
@dulltz dulltz marked this pull request as ready for review January 17, 2020 04:25
@dulltz
Refactor
4065bbc 
Signed-off-by: dulltz <isrgnoe@gmail.com>
@dulltz dulltz assigned dulltz, morimoto-cybozu and binoue and unassigned kfyharukz Jan 17, 2020
@binoue binoue self-requested a review January 17, 2020 05:03
binoue
binoue approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@binoue binoue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mobbed

@binoue binoue merged commit 23aa757 into master Jan 17, 2020
@binoue binoue deleted the metrics-instrumentation branch January 17, 2020 05:04
@dulltz dulltz changed the title Add instrumentation Add Prometheus instrumentation Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binoue binoue binoue approved these changes

Assignees

@dulltz dulltz

@morimoto-cybozu morimoto-cybozu

@binoue binoue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kfyharukz @binoue @dulltz @morimoto-cybozu