[sabakan-cryptsetup] TPM 2.0 support #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update documents.
mitsutaka
force-pushed
the
cryptsetup-with-tpm
branch
from
88bdfb3
to
a47fce0
Compare
mitsutaka
force-pushed
the
cryptsetup-with-tpm
branch
5 times, most recently
from
b210050
to
e3fdfb3
Compare
mitsutaka
force-pushed
the
cryptsetup-with-tpm
branch
from
e3fdfb3
to
e7f9d5d
Compare
ymmt2005
reviewed
Jul 25, 2019
pkg/sabakan-cryptsetup/cmd/driver.go
Outdated
| }, nil | ||
| } | ||
|
|
||
| // Setup setup crypt devices. | ||
| func (d *Driver) Setup(ctx context.Context) error { | ||
| kek := []byte("") |
ymmt2005
requested changes
Jul 25, 2019
pkg/sabakan-cryptsetup/cmd/meta.go
Outdated
| func (m *Metadata) DecryptKey(ek []byte) ([]byte, error) { | ||
| if len(ek) != len(m.kek) { | ||
| return nil, fmt.Errorf("key length mismatch: expected=%d, actual=%d", len(m.kek), len(ek)) | ||
| func (m *Metadata) DecryptKey(kek, tpmKek []byte) ([]byte, error) { |
There was a problem hiding this comment.
DecryptKey の第一引数は「暗号化されたキー」であるので ek が正しくて、kek (key encryption key)ではないので元に戻してください。
added 2 commits
July 26, 2019 08:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documents.