Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust to setup-hw way #149

Merged
merged 2 commits into from
Apr 10, 2019
Merged

Adjust to setup-hw way #149

merged 2 commits into from
Apr 10, 2019

Conversation

dulltz
Copy link
Contributor

@dulltz dulltz commented Apr 10, 2019

Build binaries in CI, then copy them to container image

@dulltz dulltz force-pushed the build-image branch 4 times, most recently from 60198c5 to 0af55b2 Compare April 10, 2019 06:12
@dulltz dulltz marked this pull request as ready for review April 10, 2019 06:16
@dulltz
Adjust to setup-hw way
3a837d3 
Build binaries in CI, then copy them to container image
satoru-takeuchi
satoru-takeuchi previously approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@satoru-takeuchi satoru-takeuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ymmt2005
ymmt2005 requested changes Apr 10, 2019
View reviewed changes
Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mode of install-tools erroneously changed to 644.

ymmt2005
ymmt2005 approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymmt2005 ymmt2005 merged commit 55fdd24 into master Apr 10, 2019
@ymmt2005 ymmt2005 deleted the build-image branch April 10, 2019 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymmt2005 ymmt2005 ymmt2005 approved these changes

@satoru-takeuchi satoru-takeuchi satoru-takeuchi left review comments

Assignees

@dulltz dulltz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dulltz @ymmt2005 @satoru-takeuchi