Add new constraint for retiring-to-retired transition #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morimoto-cybozu
force-pushed
the
add-new-transition-constraint
branch
from
bd3fd56
to
d3accd1
Compare
ymmt2005
requested changes
Mar 3, 2019
docs/api.md
Outdated
| @@ -299,6 +300,10 @@ The new state is given by contents of request body and should be one of: | |||
|
|
|||
| HTTP status code: 400 Bad Request | |||
|
|
|||
| - Disk encryption keys have not been deleted. | |||
There was a problem hiding this comment.
ちょっと伝わりにくいです。例えば
Suggested change
| - Disk encryption keys have not been deleted. | |
| - Transitioning a retiring server that still have disk encryption keys to be retired. |
docs/lifecycle.md
Outdated
| * Disk encryption keys of a machine can be deleted if the machine is in **Retiring** state. | ||
| * A machine transitions to **Retired** when its disk encryption keys are deleted. | ||
| * A **Retiring** machine can transition to **Retired** only when its disk encryption keys have been deleted. |
There was a problem hiding this comment.
Suggested change
| * A **Retiring** machine can transition to **Retired** only when its disk encryption keys have been deleted. | |
| * A **Retiring** machine can transition to **Retired** only when it has no disk encryption keys. |
docs/sabactl.md
Outdated
| Deletes all keys of a machine, and make its status `retired`. | ||
| The command fails when the target machine's status is not `retiring`. | ||
| Deletes all keys of a machine. | ||
| The command fails when the target machine's status is not `retiring`, or when the target machine's disk encryption keys have not been deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.