Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sabakan-cryptsetup] support multiple ciphers #142

Merged
merged 5 commits into from
Feb 25, 2019
Merged

Conversation

ymmt2005
Copy link
Member

@ymmt2005 ymmt2005 commented Feb 22, 2019

This PR revamps sabakan-cryptsetup to:

  • Auto detect physical disks to be encrypted,
  • Document formal specifications, and
  • Support cipher and key size selection

Additionally, this PR adds a new API at /api/v1/cryptsetup to download
sabakan-cryptsetup. The location of sabakan-cryptsetup is specified by
SABAKAN_CRYPTSETUP environment variable.

If SABAKAN_CRYPTSETUP is not set, sabakan looks for sabakan-cryptsetup
in the same directory where sabakan exists.

@ymmt2005 ymmt2005 added the wip label Feb 22, 2019
@ymmt2005 ymmt2005 changed the title WIP [sabakan-cryptsetup] support multiple ciphers Feb 22, 2019
@ymmt2005 ymmt2005 removed the wip label Feb 24, 2019
@ymmt2005 ymmt2005 force-pushed the cbc-essiv branch 4 times, most recently from 170721a to fa254b6 Compare February 25, 2019 01:46
/api/v1/cryptsetup: download sabakan-cryptsetup binary

The binary location is specified by SABAKAN_CRYPTSETUP environment
variable.  The default location is the same directory of sabakan
executable.
YujiEda
YujiEda previously approved these changes Feb 25, 2019
Copy link
Contributor

@morimoto-cybozu morimoto-cybozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morimoto-cybozu morimoto-cybozu merged commit aa10e54 into master Feb 25, 2019
@morimoto-cybozu morimoto-cybozu deleted the cbc-essiv branch February 25, 2019 06:54
@morimoto-cybozu
Copy link
Contributor

これのリリースは RC からやるのかしら。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants