-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sabakan-cryptsetup] support multiple ciphers #142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymmt2005
force-pushed
the
cbc-essiv
branch
4 times, most recently
from
February 25, 2019 01:46
170721a
to
fa254b6
Compare
/api/v1/cryptsetup: download sabakan-cryptsetup binary The binary location is specified by SABAKAN_CRYPTSETUP environment variable. The default location is the same directory of sabakan executable.
YujiEda
previously approved these changes
Feb 25, 2019
morimoto-cybozu
approved these changes
Feb 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
これのリリースは RC からやるのかしら。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revamps
sabakan-cryptsetup
to:Additionally, this PR adds a new API at
/api/v1/cryptsetup
to downloadsabakan-cryptsetup
. The location ofsabakan-cryptsetup
is specified bySABAKAN_CRYPTSETUP
environment variable.If
SABAKAN_CRYPTSETUP
is not set,sabakan
looks forsabakan-cryptsetup
in the same directory where
sabakan
exists.