Revamp Ignition template #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymmt2005
changed the title
ymmt2005
force-pushed
the
revamp-metadata-api
branch
from
33e7cad
to
5e94ac9
Compare
There are a lot of internal changes, although old template YAML can be read with the new implementation.
ymmt2005
force-pushed
the
revamp-metadata-api
branch
from
5e94ac9
to
f0d379d
Compare
ymmt2005
force-pushed
the
revamp-metadata-api
branch
2 times, most recently
from
932255e
to
f61cce2
Compare
This is because the latest stable channel of CoreOS Container Linux supports Ignition 2.2 only.
ymmt2005
force-pushed
the
revamp-metadata-api
branch
from
f61cce2
to
064a1ca
Compare
|
cybozu-go/neco/dctest 環境でのコンバージョン結果： $ sudo systemctl stop sabakan.service
$ sudo ./sabakan --config-file=/etc/sabakan/config.yml
2019-02-17T16:17:42.227886Z boot-0 sabakan info: "upgrading schema version" from="1" to="3"
2019-02-17T16:17:42.292239Z boot-0 sabakan info: "updated schema version" to="2"
2019-02-17T16:17:42.373377Z boot-0 sabakan info: "updated schema version" to="3"
2019-02-17T16:17:42.401696Z boot-0 sabakan info: "resume stateful watching" rev=528$ ./sabactl ignitions get worker
["9999.99.99"]
$ ./sabactl ignitions get worker 9999.99.99 | jq .template | jq -r '.storage.files[0].contents.source'
data:,LABEL%3Dcontainerd%20%2Fvar%2Flib%2Fcontainerd%20ext4%20x-systemd.device-timeout%3D600%200%200%0ALABEL%3Ddocker%20%20%20%20%20%2Fvar%2Flib%2Fdocker%20%20%20%20%20ext4%20x-systemd.device-timeout%3D600%200%200%0ALABEL%3Dkubelet%20%20%20%20%2Fvar%2Flib%2Fkubelet%20%20%20%20ext4%20x-systemd.device-timeout%3D600%200%200%0ALABEL%3Drkt%20%20%20%20%20%20%20%20%2Fvar%2Flib%2Frkt%20%20%20%20%20%20%20%20ext4%20x-systemd.device-timeout%3D600%200%200%0A意図通りに変換されている。この状態で host-vm$ sudo pmctl node action restart rack0-cs1
host-vm$ sudo pmctl node enter rack0-cs1
...
[ OK ] Started Wait for chrony to synchronize system clock.
[ OK ] Reached target System Time Synchronized.
[ OK ] Started Daily Log Rotation.
Starting Docker Socket for the API.
[ OK ] Listening on Docker Socket for the API.
Starting setup-hw container...
Starting Load coil container image...
Starting Load Squid container image...
Starting Load container images for CKE...
[ OK ] Started containerd container runtime.
Starting Docker Application Container Engine...
[ OK ] Started Docker Application Container Engine.
[ OK ] Started Load coil container image.
[ OK ] Started Load Squid container image.
[ OK ] Started setup-hw container.
Starting Run setup-hw tool...
[ OK ] Started Load container images for CKE.
[ OK ] Started Wait for Network to be Configured.
[ OK ] Started Run setup-hw tool.
Starting Serf container on docker...
[ OK ] Started Serf container on docker.
[ OK ] Started Set serf tags periodically.
[ OK ] Reached target Multi-User System. |
ymmt2005
requested review from
binoue,
dulltz and
morimoto-cybozu
and removed request for
dulltz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revamps ignition template implementations.
Changes in REST APIs and command-line usage break backward-compatibility.
Changes in template syntax do not break backward-compatibility.
Template data in etcd are converted automatically.
The etcd schema version is bumped to 3.
One most notable change is that sabakan can now handle multiple Ignition specification versions.
To define an ignition template for spec version 2.3.0, specify
versionin template YAML as follows: