Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arithmetic functions for Ignition templates, et al. #137

Merged
merged 5 commits into from
Feb 14, 2019

Conversation

ymmt2005
Copy link
Member

@ymmt2005 ymmt2005 commented Feb 13, 2019

This PR adds arithmetic functions for Ignition templates.

Other changes to be included are:

  • Initialization of schema version.
  • Make Ignition template meta data API better.

also fixes a potential problem in convertTo2 method
that set the schema version to the current version
instead of "2".
@ymmt2005 ymmt2005 changed the title Initialize schema version. Arithmetic functions for Ignition templates, et al. Feb 13, 2019
@ymmt2005 ymmt2005 added the wip label Feb 13, 2019
Copy link
Contributor

@morimoto-cybozu morimoto-cybozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morimoto-cybozu morimoto-cybozu merged commit 9b9c66a into master Feb 14, 2019
@morimoto-cybozu morimoto-cybozu deleted the arithmetic branch February 14, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants