Add BMC NIC configuration information to Machine #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymmt2005
changed the title
As a part of this commit, IPAMConfig has a new mandatory field "bmc-ipv4-gateway-offset". JSON API requires that the field must be non-zero. This is a backward-breaking change.
ymmt2005
force-pushed
the
bmc-info
branch
3 times, most recently
from
03d45be
to
584c284
Compare
Ignition template is now rendered with Machine instead of MachineSpec to provide broader range of information. This is backward-incompatible change.
zoetrope
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two backward-breaking changes:
IPAMConfighas a new mandatory field "bmc-ipv4-gateway-offset".The field value must be non-zero. JSON API for
IPAMConfigrequires the field now.Ignition template now receives
Machineinstead ofMachineSpec.Existing templates that reference the spec such as
.Rackneed to be updated to.Spec.Rack.