Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignition rendering #131

Merged
merged 5 commits into from
Dec 26, 2018
Merged

Fix ignition rendering #131

merged 5 commits into from
Dec 26, 2018

Conversation

ueokande
Copy link
Member

No description provided.

docs/ignition.md Outdated
contents:
source: "{{ .Serial }}"`,
Sabakan generates ignitions from ignition-like template in JSON via REST API.
This format contains control sequence in in `text.Template` to apply machine's specs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/in in/in/

docs/ignition.md Outdated
source: "{{ .Serial }}"`,
Sabakan generates ignitions from ignition-like template in JSON via REST API.
This format contains control sequence in in `text.Template` to apply machine's specs.
To render contents in `storage.files.contents.source`, the values is plane text
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/plane/plain/

Copy link
Contributor

@mitsutaka mitsutaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsutaka mitsutaka merged commit 5b9df5c into master Dec 26, 2018
@mitsutaka mitsutaka deleted the fix-ignition-rendering branch December 26, 2018 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants