Fix random Nav2 failure with Fast DDS #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad-daniel
requested changes
Mar 13, 2023
There was a problem hiding this comment.
Shouldn't rolling require the same patch? It doesn't appear to be a solved yet based on the discussion you linked, so that distro should have the same issue no?
Also might be a good idea to leave a comment that references this PR or the linked one for future reference, as this fix only bypasses the issue, and therefore I assume that if somebody installs webots_ros2 locally he might face the same problems since these bash scripts aren't run locally
|
If the error is completely fixed on the Fast-DDS package in the future, we may remove this fix. Also I have added a section in the TIAGo instuctions so that users that encounter the issue locally can use the temporary solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nav2 random failures in the TIAGo tests are due to issues with the default Fast DDS on Humble. See ros-navigation/navigation2#3033 (comment) comment and issue.
We switch the DDS to Cyclone to fix the problem.