Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the path of conjur.properties configurable #105

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bnasslahsen
Copy link
Contributor

Desired Outcome

  • The goal of this PR is to make the path of conjur.properties configurable through spring-boot properties
  • The current is hardcoding the path of the conjur.properties, making it possible to declare the path of secrets after the binary (jars, docker images, ...) are built.

Implemented Changes

Describe how the desired outcome above has been achieved with this PR. In
particular, consider:

This PR introduces new property conjur.mapping-path that allow the developer to explicitly set the path of conjur.properties

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

Copy link
Contributor

@stefanskicyber stefanskicyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok.
Changes were tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants