Fixed default mapping when lambda function called

[bsekachev]

Motivation and context

make_default_mapping didn't work well for lambda functions with attributes

Related #8213

How has this been tested?

Checklist

• I submit my changes into the develop branch
• I have created a changelog fragment
• I have updated the documentation accordingly
• I have added tests to cover my changes
• I have linked related issues (see GitHub docs)
• I have increased versions of npm packages if it is necessary
  (cvat-canvas,
  cvat-core,
  cvat-data and
  cvat-ui)

License

• I submit my code changes under the same MIT License that covers the project.
  Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

• New Features

  • Improved mapping functionality by generating default mappings based on task labels instead of model labels.

• Bug Fixes

  • Simplified the validation process for attribute mappings, ensuring consistent behavior when creating mappings.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent changes enhance the make_default_mapping and validate_attributes_mapping functions, shifting the focus from model labels to task labels for mapping generation and validation. This adjustment streamlines the logic, ensuring that task-specific attributes are prioritized, which may significantly impact the behavior of the mapping process.

Changes

Files	Change Summary
cvat/apps/lambda_manager/views.py	Modified make_default_mapping to use task_label attributes instead of model_label. Simplified the logic in validate_attributes_mapping, removing conditionals that previously checked for existing mappings.

Poem

In a field where the rabbits play,
Changes hop along the way,
With task labels now in sight,
Mappings dance in pure delight!
So let's celebrate, with a cheer,
For the bright paths that now appear! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e0da3a2 and f8c9b70.

Files selected for processing (1)

• cvat/apps/lambda_manager/views.py (2 hunks)

Additional comments not posted (2)

cvat/apps/lambda_manager/views.py (2)

274-276: Shift focus from model labels to task labels.

The inner loop now iterates over task_label.attributespec_set.all() instead of model_label.attributespec_set.all(). This change ensures that the attributes_default_mapping dictionary is built using attributes from the task label, which aligns with the intended functionality to prioritize task-specific attributes.

---

352-352: Simplification of mapping validation logic.

The conditional check that determined whether to call make_default_mapping or validate_labels_mapping has been removed. Now, make_default_mapping is always called with model_labels and task_labels, which simplifies the logic but may lead to different behavior when a mapping already exists.

Ensure that this change does not introduce unintended side effects, especially in scenarios where a mapping is already present.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.32%. Comparing base (e0da3a2) to head (4a26e32).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #8250      +/-   ##
===========================================
- Coverage    83.36%   83.32%   -0.05%     
===========================================
  Files          388      388              
  Lines        41395    41395              
  Branches      3856     3856              
===========================================
- Hits         34508    34491      -17     
- Misses        6887     6904      +17     

Components	Coverage Δ
cvat-ui	79.64% <ø> (-0.09%)	⬇️
cvat-server	86.60% <0.00%> (ø)