Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing migration #8162

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Add missing migration #8162

merged 1 commit into from
Jul 15, 2024

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Jul 12, 2024

Motivation and context

Follow up for #8144

  • Added a seemingly missing migration

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • Chores
    • Updated database schema to improve relationship consistency within the application. No visible changes for end-users.

Copy link
Contributor

coderabbitai bot commented Jul 12, 2024

Walkthrough

The recent update introduces a Django migration that modifies the trackedshape model in the engine app. Specifically, it alters the track field to establish a new foreign key relationship with the labeledtrack model. This change impacts the way these models are related, ensuring better data integrity and potentially optimizing database queries.

Changes

File Change Summary
cvat/apps/engine/migrations/0080_alter_trackedshape_track.py Altered the track field in the trackedshape model to be a foreign key to labeledtrack within the engine app.

Poem

In the database, a field did change,
To optimize the model's range,
A foreign key, now set anew,
For trackedshape and labeledtrack too.
Relationships strong, the code refined,
In the data's heart, they’re now aligned.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zhiltsov-max zhiltsov-max requested review from SpecLad and removed request for Marishka17 July 12, 2024 19:06
Copy link

sonarcloud bot commented Jul 12, 2024

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9565cff and 331ea0b.

Files selected for processing (1)
  • cvat/apps/engine/migrations/0080_alter_trackedshape_track.py (1 hunks)
Additional comments not posted (3)
cvat/apps/engine/migrations/0080_alter_trackedshape_track.py (3)

1-1: Confirm migration generation timestamp.

Ensure that the timestamp matches the intended migration creation time to avoid conflicts with other migrations.


14-23: Field alteration correctness.

The track field in the trackedshape model is updated to reference engine.LabeledTrack with on_delete=models.CASCADE, related_name="shapes", and related_query_name="shape". This change looks correct.


10-11: Dependencies check.

The migration depends on 0079_alter_labeledimageattributeval_image_and_more. Ensure that this migration exists and is correctly applied before this one.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.42%. Comparing base (9565cff) to head (331ea0b).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8162      +/-   ##
===========================================
- Coverage    83.43%   83.42%   -0.01%     
===========================================
  Files          388      388              
  Lines        41272    41272              
  Branches      3852     3852              
===========================================
- Hits         34435    34433       -2     
- Misses        6837     6839       +2     
Components Coverage Δ
cvat-ui 79.72% <ø> (-0.01%) ⬇️
cvat-server 86.75% <ø> (-0.01%) ⬇️

@zhiltsov-max zhiltsov-max requested review from bsekachev and removed request for SpecLad July 15, 2024 07:12
@zhiltsov-max zhiltsov-max mentioned this pull request Jul 15, 2024
7 tasks
@zhiltsov-max zhiltsov-max merged commit 2aa4ebd into develop Jul 15, 2024
33 checks passed
@zhiltsov-max zhiltsov-max deleted the zm/sync-migrations branch July 15, 2024 08:00
zhiltsov-max added a commit that referenced this pull request Jul 15, 2024
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->

<!-- Provide a general summary of your changes in the Title above -->

Depends on #8162

### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->

- Added recording and reporting of the last assignee update time on the
server
- Added reporting of the assignee in quality reports

### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

Unit tests

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [ ] I submit my changes into the `develop` branch
- [ ] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))

### License

- [ ] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Added tracking for the last assignee update time across jobs, tasks,
and projects.
  - Introduced assignee information in quality reports.
- **Bug Fixes**
- Ensured accurate handling of assignee details and update times in
various entities.
- **Tests**
- Added extensive test coverage for creating and updating assignee
details in jobs, tasks, projects, and quality reports.
- **Documentation**
  - Updated schema to include the new `assignee_updated_date` field.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants