Optimized number of queries on GET /projects, GET /project/<id>/preview and GET /labels endpoints.
#8155
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes involve optimizing data processing in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://github.com/avatars/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- cvat/apps/engine/serializers.py (1 hunks)
- cvat/apps/engine/views.py (3 hunks)
Additional comments not posted (6)
cvat/apps/engine/serializers.py (2)
1347-1348: Good use of generators for memory efficiency!Using generators to collect
subsetsanddimensionsis a memory-efficient improvement.
1349-1352: Ensure the first dimension is correctly retrievedThe use of
next(dimensions, None)retrieves the first dimension orNoneif the generator is empty. Verify that this behavior is intended and correct.cvat/apps/engine/views.py (4)
292-293: Ensure correctness of the filtering logic forpreviewaction.The code changes are approved.
However, ensure that the filtering logic for the
previewaction is appropriate and efficient.
630-630: Ensure correctness of the data fetching logic for the first task inpreviewmethod.The code changes are approved.
However, ensure that necessary related data is included and the method handles cases where no tasks are available.
869-870: Ensure correctness of the filtering logic forpreviewaction.The code changes are approved.
However, ensure that the filtering logic for the
previewaction is appropriate and efficient.
870-870: Ensure correctness of the data fetching logic for the first task inpreviewmethod.The code changes are approved.
However, ensure that necessary related data is included and the method handles cases where no tasks are available.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8155 +/- ##
==========================================
Coverage ? 83.31%
==========================================
Files ? 388
Lines ? 41354
Branches ? 3856
==========================================
Hits ? 34454
Misses ? 6900
Partials ? 0
|
bsekachev
changed the title
/projects, GET /project/<id>/preview and GET /labels endpoints.
cvat/apps/engine/views.py
Outdated
| if self.action in ('list', 'retrieve', 'partial_update', 'update') : | ||
| queryset = queryset.select_related( | ||
| 'annotation_guide', 'source_storage', 'target_storage', | ||
| ).prefetch_related('tasks') |
There was a problem hiding this comment.
How about export/import backup/dataset v1/v2? I remember that at least target_storage/source_storage is used when exporting/importing a project resource.
There was a problem hiding this comment.
Added 'source_storage', 'target_storage' to the default queryset.
|
@Marishka17 |
|
Motivation and context
Retrieving a list of projects and previews:
Before:
After:
Retrieving a list of labels for a project O(number of labels) with 10 labels:
Before:
After:
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
New Features
Bug Fixes