Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "classifier" compatibility alias #8096

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Jun 27, 2024

Motivation and context

I adjusted the Roboflow/HF function code to not produce this value anymore, so this alias is no longer needed.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • [ ] I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • Refactor
    • Removed outdated 'classifier' value and compatibility logic from ML model handling.

I adjusted the Roboflow/HF function code to not produce this value anymore,
so this alias is no longer needed.
@SpecLad SpecLad requested a review from bsekachev as a code owner June 27, 2024 11:56
Copy link
Contributor

coderabbitai bot commented Jun 27, 2024

Walkthrough

The changes simplify the SerializedModel interface and the MLModel class by removing references to the string value 'classifier'. This involves eliminating both the 'classifier' value from the kind property in SerializedModel and the compatibility logic in the MLModel class that formerly converted 'classifier' to ModelKind.DETECTOR.

Changes

File Change Summary
cvat-core/src/core-types.ts Removed the specific string value 'classifier' from the kind property in SerializedModel.
cvat-core/src/ml-model.ts Removed the compatibility alias logic that converted 'classifier' to ModelKind.DETECTOR in MLModel.

Poem

Changes blow through the code like a breeze,
Simplifying logic, it's done with ease.
Goodbye, classifier, no longer in mind,
Just detectors remain, sleek and refined.
Underneath the hood, it's clean and bright,
Let's celebrate code that feels just right! 🎉🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 79927bf and 76f6943.

Files selected for processing (2)
  • cvat-core/src/core-types.ts (1 hunks)
  • cvat-core/src/ml-model.ts (1 hunks)
Files skipped from review due to trivial changes (2)
  • cvat-core/src/core-types.ts
  • cvat-core/src/ml-model.ts

@SpecLad SpecLad merged commit ab7ce81 into cvat-ai:develop Jun 28, 2024
32 checks passed
@SpecLad SpecLad deleted the rd/rm-classifier-alias branch June 28, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants