Minor fix in layout when running automatic annotations #8072
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe recent changes enhance the user interface of CVAT's Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
![coderabbitai[bot]](https://github.com/avatars/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- cvat-ui/src/components/model-runner-modal/object-mapper.tsx (4 hunks)
- cvat-ui/src/components/model-runner-modal/styles.scss (2 hunks)
Additional comments not posted (7)
cvat-ui/src/components/model-runner-modal/styles.scss (3)
22-22: Ensure overflow behavior is as expected.The addition of
overflow: hidden auto;will hide the horizontal overflow and provide a scrollbar for vertical overflow. Confirm this behavior aligns with the design requirements.
28-28: Confirm spacing adjustments.The change from padding to margin could affect the layout spacing. Ensure this change aligns with the intended design, especially in responsive contexts.
44-44: Check for consistent spacing in nested elements.Similar to the previous comment, verify that the adjustment from padding to margin on
.cvat-runner-attribute-mappermaintains the intended visual hierarchy and spacing.cvat-ui/src/components/model-runner-modal/object-mapper.tsx (4)
81-81: Review grid layout adjustment.The reduction in grid span for this column might be intended to better align or fit other elements. Ensure that this change does not cause any visual or functional regression in the layout.
84-84: Confirm layout consistency.As with the previous column, this change should be reviewed to ensure it maintains consistency and alignment with other UI elements.
87-87: Validate spacing for interactive elements.Increasing the span and offset for the column containing the delete icon may improve accessibility or visibility. Confirm that this adjustment enhances user interaction without disrupting the overall layout.
Ensure alignment and functionality of select components.
The changes in the span and offset for the select components should be checked to ensure they align correctly with other elements and that their functionality remains intact in various screen sizes.
148-148: Check conditional rendering for tooltips.The conditional rendering logic for displaying different tooltips based on the state should be thoroughly tested to ensure it behaves as expected under all conditions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8072 +/- ##
===========================================
- Coverage 83.64% 83.62% -0.02%
===========================================
Files 383 383
Lines 40439 40439
Branches 3815 3815
===========================================
- Hits 33825 33817 -8
- Misses 6614 6622 +8
|
Motivation and context
Before:
After:
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit