Fixed extra server requests

[bsekachev]

Motivation and context

Requests before fix when changing job stage (task in a project, project not in app state):

After fix:

How has this been tested?

Checklist

• I submit my changes into the develop branch
• I have created a changelog fragment
• I have updated the documentation accordingly
• I have added tests to cover my changes
• I have linked related issues (see GitHub docs)
• I have increased versions of npm packages if it is necessary
  (cvat-canvas,
  cvat-core,
  cvat-data and
  cvat-ui)

License

• I submit my code changes under the same MIT License that covers the project.
  Feel free to contact the maintainers if that's a concern.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent changes involve updates to the cvat-core and cvat-ui files relating to project subset handling. The taskSubsets property in the Project class has been renamed to subsets, and adjustments were made to component props and logic to accommodate this change and handle subsets more appropriately, especially when dealing with null values.

Changes

File Path	Change Summary
cvat-core/src/project.ts	Renamed taskSubsets to subsets in the Project class.
cvat-ui/src/components/create-task-page/create-task-content.tsx	Added projectSubsets prop with a value of null to ProjectSubsetField component.
cvat-ui/src/components/create-task-page/project-subset-field.tsx	Changed projectSubsets type and adjusted conditional logic related to it.
cvat-ui/src/components/task-page/details.tsx	Updated imports, restructured mapStateToProps, removed projectSubsets, adjusted logic.

Sequence Diagram(s)

• N/A (The changes are mostly property renaming and type adjustments, which do not significantly impact the control flow.)

Poem

In fields of code where subsets play,
We named them new to clear the way.
With props and types now clear and true,
The tasks and projects thrive anew.
A bunny's cheer for changes made,
In CVAT's core a smoother grade!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2a720f4 and 27575d2.

Files selected for processing (4)

• cvat-core/src/project.ts (1 hunks)
• cvat-ui/src/components/create-task-page/create-task-content.tsx (1 hunks)
• cvat-ui/src/components/create-task-page/project-subset-field.tsx (2 hunks)
• cvat-ui/src/components/task-page/details.tsx (4 hunks)

Files not reviewed due to errors (2)

• cvat-core/src/project.ts (no review received)
• cvat-ui/src/components/create-task-page/create-task-content.tsx (no review received)

Additional comments not posted (6)

cvat-ui/src/components/create-task-page/project-subset-field.tsx (3)

22-22: Updated subsets property in ProjectPartialWithSubsets.

The change aligns the subsets property with the new expected type. This is a straightforward change and seems correctly implemented.

---

34-34: Refactor conditional logic in useEffect.

The updated conditional logic checks if projectSubsets is null instead of checking its length. This change is consistent with the new nullable type of projectSubsets. It's a good practice to handle potentially null values to prevent runtime errors.

---

15-15: Clarify the projectSubsets prop in the Props interface.

The projectSubsets prop has been changed to either an array of strings or null. This is a significant change as it affects how the component handles the absence of subsets. Ensure that all usages of this prop across the project handle the null case appropriately.

cvat-ui/src/components/task-page/details.tsx (3)

14-17: Updated import statements to include new classes.

The import statements now include Dumper, User, Project, and Task from cvat-core-wrapper. This change is necessary for the updated usage of these classes in the component.

---

35-37: Updated types in StateToProps interface.

The dumpers type has been clarified to be an array of Dumper and user to be of type User. This change improves type safety and aligns with TypeScript best practices.

---

48-50: Refactored mapStateToProps function.

The function now handles the project property differently, which is aligned with the new structure of the Project class. It's crucial to ensure that the rest of the application correctly handles the potential undefined state of project.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud