Migrate quality UI changes #7441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into kl/quality-bugfixes
|
@klakhov Could you please merge with develop? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7441 +/- ##
===========================================
- Coverage 83.55% 83.52% -0.03%
===========================================
Files 375 373 -2
Lines 39752 39689 -63
Branches 3734 3718 -16
===========================================
- Hits 33213 33151 -62
+ Misses 6539 6538 -1
|
bsekachev
reviewed
Feb 12, 2024
bsekachev
reviewed
Feb 12, 2024
cvat-ui/src/components/analytics-page/task-quality/task-quality-component.tsx
Outdated
Show resolved
Hide resolved
bsekachev
reviewed
Feb 12, 2024
bsekachev
reviewed
Feb 12, 2024
bsekachev
reviewed
Feb 15, 2024
cvat-ui/src/utils/hooks.ts
Outdated
Comment on lines
37
to
42
| export function useStateIfMounted<T>(defaultValue: T): [T, (t: T) => void] { | ||
| const isMounted = useIsMounted(); | ||
| const [state, setState] = useState<T>(defaultValue); | ||
| const wrappedSetState = useCallback((val: T) => isMounted() && setState(val), []); | ||
| return [state, wrappedSetState]; | ||
| } |
There was a problem hiding this comment.
I suppose now it may be removed
Comment on lines
31
to
38
| fetching: boolean, | ||
| taskReport: QualityReport | null, | ||
| jobsReports: QualityReport[], | ||
| qualitySettings: { | ||
| settings: QualitySettings | null, | ||
| fetching: boolean, | ||
| visible: boolean, | ||
| }, |
There was a problem hiding this comment.
Suggested change
| fetching: boolean, | |
| taskReport: QualityReport | null, | |
| jobsReports: QualityReport[], | |
| qualitySettings: { | |
| settings: QualitySettings | null, | |
| fetching: boolean, | |
| visible: boolean, | |
| }, | |
| fetching: boolean; | |
| taskReport: QualityReport | null; | |
| jobsReports: QualityReport[]; | |
| qualitySettings: { | |
| settings: QualitySettings | null; | |
| fetching: boolean; | |
| visible: boolean; | |
| }; |
Comment on lines
26
to
27
| task: Task, | ||
| onJobUpdate: (job: Job) => void |
There was a problem hiding this comment.
Suggested change
| task: Task, | |
| onJobUpdate: (job: Job) => void | |
| task: Task; | |
| onJobUpdate: (job: Job) => void; |
bsekachev
reviewed
Feb 15, 2024
Comment on lines
300
to
316
| frame_count: number, | ||
| frame_share: number, | ||
| conflict_count: number, | ||
| valid_count: number, | ||
| ds_count: number, | ||
| gt_count: number, | ||
| error_count: number, | ||
| warning_count: number, | ||
| conflicts_by_type: { | ||
| extra_annotation: number, | ||
| missing_annotation: number, | ||
| mismatching_label: number, | ||
| low_overlap: number, | ||
| mismatching_direction: number, | ||
| mismatching_attributes: number, | ||
| mismatching_groups: number, | ||
| covered_annotation: number, |
There was a problem hiding this comment.
Suggested change
| frame_count: number, | |
| frame_share: number, | |
| conflict_count: number, | |
| valid_count: number, | |
| ds_count: number, | |
| gt_count: number, | |
| error_count: number, | |
| warning_count: number, | |
| conflicts_by_type: { | |
| extra_annotation: number, | |
| missing_annotation: number, | |
| mismatching_label: number, | |
| low_overlap: number, | |
| mismatching_direction: number, | |
| mismatching_attributes: number, | |
| mismatching_groups: number, | |
| covered_annotation: number, | |
| frame_count: number; | |
| frame_share: number; | |
| conflict_count: number; | |
| valid_count: number; | |
| ds_count: number; | |
| gt_count: number; | |
| error_count: number; | |
| warning_count: number; | |
| conflicts_by_type: { | |
| extra_annotation: number; | |
| missing_annotation: number; | |
| mismatching_label: number; | |
| low_overlap: number; | |
| mismatching_direction: number; | |
| mismatching_attributes: number; | |
| mismatching_groups: number; | |
| covered_annotation: number; |
bsekachev
approved these changes
Feb 15, 2024
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
This PR moves some UI changes from #6367
Now it includes:
cvat-uiHow has this been tested?
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.