Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click instead of hover to open dropdown menus #7431

Merged
merged 41 commits into from
Feb 9, 2024

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Feb 2, 2024

Motivation and context

Before different dropdown menus are opened on hover.
It was decided to change the behaviour and open them by click only.

Affected menus:

  • Project page: Actions menu
  • Projects page: Actions menu
  • Task page: Actions menu
  • Task page: Job actions menu
  • Tasks page: Actions menu
  • Jobs page: Actions menu
  • Cloud storages page: Action menu
  • Models page: Actions menu
  • Annotation view: Menu button
  • Annotation view: Controls on side panel
  • Annotation view: Objects context menu
  • Annotation view: Filters modal => Recent filters
  • Header: User menu button
  • Webhooks page : Action menu
  • Invitation page: Action menu
  • Organization page: Action menu

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@cvat-ai cvat-ai deleted a comment from github-actions bot Feb 2, 2024
@cvat-ai cvat-ai deleted a comment from github-actions bot Feb 2, 2024
@cvat-ai cvat-ai deleted a comment from github-actions bot Feb 5, 2024
@cvat-ai cvat-ai deleted a comment from github-actions bot Feb 5, 2024
@cvat-ai cvat-ai deleted a comment from github-actions bot Feb 5, 2024
@cvat-ai cvat-ai deleted a comment from github-actions bot Feb 5, 2024
@cvat-ai cvat-ai deleted a comment from github-actions bot Feb 5, 2024
@cvat-ai cvat-ai deleted a comment from github-actions bot Feb 5, 2024
@bsekachev bsekachev marked this pull request as ready for review February 5, 2024 12:31
@cvat-ai cvat-ai deleted a comment from github-actions bot Feb 6, 2024
@cvat-ai cvat-ai deleted a comment from github-actions bot Feb 6, 2024
@cvat-ai cvat-ai deleted a comment from github-actions bot Feb 6, 2024
@cvat-ai cvat-ai deleted a comment from github-actions bot Feb 6, 2024
@cvat-ai cvat-ai deleted a comment from github-actions bot Feb 6, 2024
@cvat-ai cvat-ai deleted a comment from github-actions bot Feb 6, 2024
@cvat-ai cvat-ai deleted a comment from github-actions bot Feb 7, 2024
@bsekachev
Copy link
Member Author

/check

Copy link
Contributor

github-actions bot commented Feb 7, 2024

✔️ All checks completed successfully
📄 See logs here

@bsekachev
Copy link
Member Author

/check

Copy link
Contributor

github-actions bot commented Feb 7, 2024

✔️ All checks completed successfully
📄 See logs here

@bsekachev
Copy link
Member Author

/check

Copy link
Contributor

github-actions bot commented Feb 7, 2024

✔️ All checks completed successfully
📄 See logs here

@klakhov
Copy link
Contributor

klakhov commented Feb 7, 2024

Looked over the patch, everything looks ok.

Just one question: Should we import <Menu> now only from components/dropdown-menu for consistency? Now I see there are a couple of files that still have import Menu from 'antd/lib/menu';

@bsekachev bsekachev merged commit 24479c0 into develop Feb 9, 2024
34 checks passed
@bsekachev bsekachev deleted the bs/update_dropdown_triggers branch February 12, 2024 13:29
@cvat-bot cvat-bot bot mentioned this pull request Feb 23, 2024
@SpecLad SpecLad mentioned this pull request Jun 10, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants