Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add absent skeleton elements automatically in cvat-core #7302

Merged
merged 14 commits into from
Jan 3, 2024

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Dec 29, 2023

Motivation and context

image
  • Added shadow to job item menu:
image
  • Fixed console error (Error: <rect> attribute width: A negative value is not valid. ("-18014398509481942")) on outside skeletons

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev marked this pull request as ready for review January 2, 2024 11:21
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Merging #7302 (23fbecd) into develop (c585209) will decrease coverage by 0.01%.
The diff coverage is 94.44%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7302      +/-   ##
===========================================
- Coverage    82.94%   82.94%   -0.01%     
===========================================
  Files          372      372              
  Lines        39570    39592      +22     
  Branches      3688     3703      +15     
===========================================
+ Hits         32821    32839      +18     
- Misses        6749     6753       +4     
Components Coverage Δ
cvat-ui 78.39% <94.44%> (-0.01%) ⬇️
cvat-server 87.11% <ø> (+<0.01%) ⬆️

@bsekachev bsekachev merged commit 397d006 into develop Jan 3, 2024
34 checks passed
@bsekachev bsekachev deleted the bs/skeletons_autofill branch January 5, 2024 08:06
@cvat-bot cvat-bot bot mentioned this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skeleton editing: right click context menu position wrong in Firefox
1 participant