Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOG serverless function + some fixes #2578

Merged
merged 33 commits into from
Feb 10, 2021
Merged

IOG serverless function + some fixes #2578

merged 33 commits into from
Feb 10, 2021

Conversation

nmanovic
Copy link
Contributor

@nmanovic nmanovic commented Dec 15, 2020

resolved #2227, resolved #2684,

Motivation and context

  • Implemented IOG serverless function for interactive segmentation. Now it isn't possible to draw a bounding box. Thus you have to add 2 negative points using 2 right clicks on the right mouse button (top left and bottom right corners of the bounding box) and a positive point in the middle of the object.

iog

  • Updated nuclio version till 1.5.16
  • All nuclio functions can be restarted after reboot (processor file is mounted as volume by nuclio mountMode: volume)
  • Interactive functions support negative points now (right click on the mouse button)
  • Refactored deploy_cpu.sh script (no code duplication anymore)
  • Fixed serverless/tensorflow/matterport/mask_rcnn

How has this been tested?

Manually deployed all functions and tested them.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev
Copy link
Member

@nmanovic
On Ubuntu 20.04 I have default installed python 3.8.5 and it leads to the next installation issues:

UnsatisfiableError: The following specifications were found
to be incompatible with the existing python installation in your environment:

Specifications:

  - torchvision=0.2 -> python[version='>=2.7,<2.8.0a0|>=3.5,<3.6.0a0|>=3.6,<3.7.0a0|>=3.7,<3.8.0a0']

Your python: python=3.8

If python is on the left-most side of the chain, that's the version you've asked for.
When python appears to the right, that indicates that the thing on the left is somehow
not available for the python version you are constrained to. Note that conda will not
change your python version to a different minor version unless you explicitly specify
that.

The following specifications were found to be incompatible with each other:

Output in format: Requested package -> Available versions

Package _libgcc_mutex conflicts for:
python=3.8 -> libgcc-ng[version='>=7.3.0'] -> _libgcc_mutex=[build=main]
pytorch=0.4 -> libgcc-ng[version='>=5.4.0'] -> _libgcc_mutex=[build=main]

The command I used: nuctl deploy --project-name cvat --path serverless/pytorch/shiyinzhang/iog/nuclio/ --platform local

@bsekachev
Copy link
Member

Also there are some issues found by codacy in Python & markdown code

@coveralls
Copy link

coveralls commented Feb 5, 2021

Coverage Status

Coverage decreased (-0.06%) to 69.751% when pulling e76be34 on nm/serverless_iog into 51c3dd8 on develop.

@bsekachev bsekachev self-assigned this Feb 8, 2021
@nmanovic
Copy link
Contributor Author

@bsekachev , @azhavoro , could you please one more time? It looks like all problems were fixed.

@bsekachev
Copy link
Member

Works, but sometime strange.
Very depends on green point position

Screenshot from 2021-02-10 16-59-01 Screenshot from 2021-02-10 17-00-05

@bsekachev
Copy link
Member

I suppose some headers in the patch were updated incorrect: 2020 -> 2021 instead of 2020-2021. What's more I don't really understand why they updated in files without any other changes

@nmanovic
Copy link
Contributor Author

Works, but sometime strange.
Very depends on green point position

Screenshot from 2021-02-10 16-59-01 Screenshot from 2021-02-10 17-00-05

from abstract for the article: Concretely, we leverage an inside point that is clicked near the object center and two outside points at the symmetrical corner locations (top-left and bottom-right or top-right and bottom-left) of a tight bounding box that encloses the target object.

@nmanovic nmanovic merged commit 97cb892 into develop Feb 10, 2021
@nmanovic nmanovic deleted the nm/serverless_iog branch February 10, 2021 14:36
@nmanovic
Copy link
Contributor Author

I suppose some headers in the patch were updated incorrect: 2020 -> 2021 instead of 2020-2021. What's more I don't really understand why they updated in files without any other changes

@azhavoro , could you please look at the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants