User search field #2370

ActiveChooN · 2020-10-28T14:32:41Z

Motivation and context

This PR provide user search field for assignee field for the task. It should increase UX with user search by username and increase loading speed for cvat.org.

How has this been tested?

Manually

Checklist

I submit my changes into the develop branch
I have added description of my changes into CHANGELOG file
~~- [ ] I have updated the documentation accordingly~~
~~- [ ] I have added tests to cover my changes~~
~~- [ ] I have linked related issues (read github docs)~~
I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

bsekachev · 2020-10-29T07:38:46Z

Could you please merge develop to CI passes?

bsekachev · 2020-10-29T16:15:40Z

It looks like some unit tests of cvat-core & cypress tests are broken

coveralls · 2020-10-30T21:38:12Z

Coverage decreased (-0.02%) to 61.514% when pulling 8c22003 on dk/user-search into a916e65 on develop.

ActiveChooN · 2020-10-30T21:45:37Z

@bsekachev, all tests was fixed

bsekachev · 2020-11-10T09:51:07Z

Now each new character creates new HTTP request. How about debouncing a user input? 0.5-1 seconds I suppose would be appropriate.

bsekachev · 2020-11-10T09:54:32Z

cvat-core/.eslintrc.js

@@ -4,6 +4,7 @@

 module.exports = {
    env: {
+        amd: true,


Why do you need it here?

Eslint warn about require usage without that flag.

Just set node to true

bsekachev · 2020-11-10T10:03:04Z

tests/cypress/integration/actions_users/case_4_assign_taks_job_users.js

@@ -86,7 +86,7 @@ context('Multiple users. Assign task, job.', () => {
        it('Assign the task to the second user and logout', () => {
            cy.openTask(taskName);
            cy.get('.cvat-task-details').within(() => {
-                cy.get('.cvat-user-selector').click({ force: true });
+                cy.get('.cvat-user-search-field').click({ force: true });


The selector .cvat-user-selector is still appear in the project (cvat-ui/src/components/task-page/styles.scss)

I suppose the styles also applicable for the new element

cvat-ui/src/components/task-page/user-selector.tsx

bsekachev · 2020-11-10T16:53:45Z

It is not very obvious how to remove assignee with current UI element. To do that I need to remove the text and click outside the input field (enter doesn't work for example). I suppose it might be more user-friendly.
One more approach which probably better I see is adding X icon at the right of input for the purpose.

bsekachev · 2020-11-10T16:55:59Z

@ActiveChooN
On other points the patch is nice and it significantly accelerates the user interface. Let's fix left comments, resolve conflicts and merge it

bsekachev · 2020-11-10T16:57:25Z

@dvkruchinin Hi, on CI we get Failed to connect to Chrome, retrying in 1 second (attempt 23/62). As far as I remember you've fixed something like that. Doesn't the fix work? Maybe try to find another ways or workarounds? It is not a rare issue

dvkruchinin · 2020-11-10T18:50:16Z

@dvkruchinin Hi, on CI we get Failed to connect to Chrome, retrying in 1 second (attempt 23/62). As far as I remember you've fixed something like that. Doesn't the fix work? Maybe try to find another ways or workarounds? It is not a rare issue

Hi,
It was more of a test. Since in the discussions, cypress users wrote that someone this fix helped, someone did not. Yes, I'll keep looking. And I want to believe that this error has become less common.

ActiveChooN · 2020-11-10T20:56:08Z

@bsekachev

It is not very obvious how to remove assignee with current UI element. To do that I need to remove the text and click outside the input field (enter doesn't work for example). I suppose it might be more user-friendly.
One more approach which probably better I see is adding X icon at the right of input for the purpose.

Added Enter button for empty search request

I suppose the styles also applicable for the new element

Strange margins here, removed styles

ActiveChooN added 3 commits October 28, 2020 17:20

Added user search filed for assignee

9e584b4

fixed eslint for cvat-core

0a5cf55

Added npm versions

ad03d80

ActiveChooN added the enhancement New feature or request label Oct 28, 2020

ActiveChooN requested review from bsekachev, nmanovic and azhavoro October 28, 2020 14:32

Added CHANGELOG

ab299b4

Merge branch 'develop' into dk/user-search

44c0bdf

ActiveChooN added 4 commits October 30, 2020 12:08

Fixed cvat-core tests

a3404df

Fixed server tests

88d4c17

Fixed empty user selector

ee7547a

Fixed cvat-ui tests

9194029

ActiveChooN requested a review from zhiltsov-max as a code owner October 30, 2020 19:58

Added debouncing for search field

1721682

bsekachev reviewed Nov 10, 2020

View reviewed changes

ActiveChooN added 2 commits November 10, 2020 21:48

Fixed PR issues

237d192

Merge remote-tracking branch 'origin/develop' into dk/user-search

8c22003

bsekachev approved these changes Nov 11, 2020

View reviewed changes

bsekachev merged commit 8334f06 into develop Nov 11, 2020

ActiveChooN deleted the dk/user-search branch November 11, 2020 10:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

User search field #2370

User search field #2370

ActiveChooN commented Oct 28, 2020 •

edited

Loading

bsekachev commented Oct 29, 2020

bsekachev commented Oct 29, 2020

coveralls commented Oct 30, 2020 •

edited

Loading

ActiveChooN commented Oct 30, 2020

bsekachev commented Nov 10, 2020

bsekachev Nov 10, 2020

ActiveChooN Nov 10, 2020

bsekachev Nov 10, 2020

bsekachev Nov 10, 2020

bsekachev Nov 10, 2020

bsekachev commented Nov 10, 2020

bsekachev commented Nov 10, 2020

bsekachev commented Nov 10, 2020

dvkruchinin commented Nov 10, 2020

ActiveChooN commented Nov 10, 2020

User search field #2370

User search field #2370

Conversation

ActiveChooN commented Oct 28, 2020 • edited Loading

Motivation and context

How has this been tested?

Checklist

License

bsekachev commented Oct 29, 2020

bsekachev commented Oct 29, 2020

coveralls commented Oct 30, 2020 • edited Loading

ActiveChooN commented Oct 30, 2020

bsekachev commented Nov 10, 2020

bsekachev Nov 10, 2020

Choose a reason for hiding this comment

ActiveChooN Nov 10, 2020

Choose a reason for hiding this comment

bsekachev Nov 10, 2020

Choose a reason for hiding this comment

bsekachev Nov 10, 2020

Choose a reason for hiding this comment

bsekachev Nov 10, 2020

Choose a reason for hiding this comment

bsekachev commented Nov 10, 2020

bsekachev commented Nov 10, 2020

bsekachev commented Nov 10, 2020

dvkruchinin commented Nov 10, 2020

ActiveChooN commented Nov 10, 2020

ActiveChooN commented Oct 28, 2020 •

edited

Loading

coveralls commented Oct 30, 2020 •

edited

Loading