Skip to content

Commit

Permalink
Fixed changing color of points shape when label is changed (#8082)
Browse files Browse the repository at this point in the history
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->

Before:

![points-before](https://github.com/cvat-ai/cvat/assets/50956430/b56655f2-ca42-4e44-938b-707cab82b8b6)
After:

![points-updated](https://github.com/cvat-ai/cvat/assets/50956430/6b7f17f6-b03b-4b42-888c-cbba0c02ec72)


### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->
Manual testing
### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [ ] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- ~~[ ] I have updated the documentation accordingly~~
- ~~[ ] I have added tests to cover my changes~~
- ~~[ ] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))~~
- [x] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Enhancements**
- Improved visualization by updating the colorization for shapes of type
'points' in the canvas view.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
klakhov committed Jun 26, 2024
1 parent cdf50d3 commit e8002b2
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
4 changes: 4 additions & 0 deletions changelog.d/20240625_173129_klakhov_fix_points_color.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
### Fixed

- Points shape color wasn't changed on changing label
(<https://github.com/cvat-ai/cvat/pull/8082>)
2 changes: 1 addition & 1 deletion cvat-canvas/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cvat-canvas",
"version": "2.20.4",
"version": "2.20.5",
"type": "module",
"description": "Part of Computer Vision Annotation Tool which presents its canvas library",
"main": "src/canvas.ts",
Expand Down
4 changes: 4 additions & 0 deletions cvat-canvas/src/typescript/canvasView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2425,6 +2425,10 @@ export class CanvasViewImpl implements CanvasView, Listener {
this.deleteObjects([this.drawnStates[+clientID]]);
this.addObjects([state]);
continue;
} else if (state.shapeType === 'points') {
const colorization = { ...this.getShapeColorization(state) };
shape.remember('_selectHandler').nested.attr(colorization);
shape.attr(colorization);
} else {
shape.attr({ ...this.getShapeColorization(state) });
}
Expand Down

0 comments on commit e8002b2

Please sign in to comment.