FIX: Remove a possibly duplicated encodeURI() (Issue #4428) (#4947)

* FIX: Remove possibly duplicated encodeURI() to prevent double encode non-ascii path (Issue #4428 Cannot connect file share，cannot recognize non-ascii path) * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Boris Sekachev <sekachev.bs@gmail.com>
cvat-ai · Sep 15, 2022 · 15565cb · 15565cb
1 parent f018a76
commit 15565cb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,7 +19,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - TDB
 
 ### Fixed
-- TDB
+- Removed a possibly duplicated encodeURI() calls in `server-proxy.ts` to prevent doubly encoding 
+non-ascii paths while adding files from "Connected file share" (issue #4428)
 
 ### Security
 - TDB

diff --git a/cvat-core/src/server-proxy.ts b/cvat-core/src/server-proxy.ts
@@ -243,13 +243,12 @@ class ServerProxy {
 
         async function share(directoryArg) {
             const { backendAPI } = config;
-            const directory = encodeURI(directoryArg);
 
             let response = null;
             try {
                 response = await Axios.get(`${backendAPI}/server/share`, {
                     proxy: config.proxy,
-                    params: { directory },
+                    params: { directory: directoryArg },
                 });
             } catch (errorData) {
                 throw generateError(errorData);