Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing props to TokenMetadata #23

Merged
merged 3 commits into from
Jan 5, 2022
Merged

Added missing props to TokenMetadata #23

merged 3 commits into from
Jan 5, 2022

Conversation

sekaiking
Copy link
Contributor

Fix #3
Fix #9

@sekaiking sekaiking mentioned this pull request Dec 13, 2021
Closed
bestatigen
bestatigen requested changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@bestatigen bestatigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of remarks, most importantly this needs changes on the front-end. Especially the deployment of the creative code static image.

as/NFT/assembly/index.ts Show resolved Hide resolved
as/NFT/assembly/models.ts Show resolved Hide resolved
as/NFT/assembly/index.ts Show resolved Hide resolved
@sekaiking sekaiking self-assigned this Dec 14, 2021
@bestatigen
Copy link
Contributor

@achrafismyname could you solve the conflict here? :)

@sekaiking
Copy link
Contributor Author

@devey done!

@bestatigen bestatigen merged commit 68695c8 into main Jan 5, 2022
@sekaiking sekaiking deleted the nft_preview branch January 24, 2022 12:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bestatigen bestatigen bestatigen approved these changes

Assignees

@sekaiking sekaiking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing props to metadata Add a preview to NFT metadata
2 participants
@sekaiking @bestatigen