-
-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch the build system to better support conda-build #7603
Conversation
/test mini |
/test mini |
FYI @kmaehashi this is ready 🙂 |
Update: I updated the PR with Windows support (from conda-forge/cupy-feedstock#228). If we plan to backport this PR, I can do it manually (the CUB path lookup needs to be patched). |
/test mini |
Update: The patch here is sync'd with conda-forge/cupy-feedstock#241. |
/test mini |
@kmaehashi Shall we try to get this merged (and backported) before the next release, so that we can avoid maintaining the patch in cupy-feedstock? |
Hi @kmaehashi any chance we can get this PR merged and backported to v13.2.0? It's getting more and more challenging for me to maintain a big patch for conda-forge... 😅 |
/test mini |
/test mini (to include now required CUDA 12.5 checks) |
Patch the build system to better support conda-build
Patch taken from conda-forge/cupy-feedstock#199.
Context:
build_shlib()
andbuild_and_run()
) that essentially checks the dependencies on the build platform (say linux64), but the actual binaries on the target platform (say aarch64) cannot be linked by the cross compiler (on linux64). A linker failure is raised when attempting to do so.Approach:
This patch has not been validated on Windows yet, becauseIt makes little sense to cross compile from linux64 to win64CUDA 12 + win64 is not supported yetAlso close #8124.