Reports already downloaded bytes as downloaded #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I got, we just send a
DownloadStatus
updating the total downloaded size if we try to download a chunk. This means that for chunks downloaded in previous runs, their bytes would be missing from the total count (i.e.DownloadedFileBytes
). I am not sure whether this is intended or not.DownloadedFileBytes
will not match the expected file size in the last statusSince most of download managers count the bytes downloaded previously towards the total bytes downloaded, I suggest we add these lines. Any ideas? Any ideas about how to test that behavior?