Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix writer:: Summarize ignoring Coloring options (#186) #189

Merged
merged 5 commits into from
Dec 13, 2021
Merged

Fix writer:: Summarize ignoring Coloring options (#186) #189

merged 5 commits into from
Dec 13, 2021

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Dec 13, 2021 •
edited by tyranron
Loading

Resolves #186

Synopsis

For now writer::Summarize ignores Coloring options.

Solution

Introduce cli::Colored trait to propagate Coloring to the outer Writers.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added bug Something isn't working enhancement Improvement of existing features or bugfix labels Dec 13, 2021
@ilslv ilslv added this to the 0.11 milestone Dec 13, 2021
@ilslv ilslv self-assigned this Dec 13, 2021
@ilslv
Copy link
Member Author

ilslv commented Dec 13, 2021 •
edited by tyranron
Loading

FCM

Fix `writer:: Summarize` ignoring `Coloring` CLI options (#189, #186)

- add `cli::Colored` trait for propagating `Coloring` to arbitrary `Writer`s

@ilslv ilslv marked this pull request as ready for review December 13, 2021 12:15
@ilslv ilslv requested a review from tyranron December 13, 2021 12:54
@tyranron tyranron changed the title Draft: Fix writer:: Summarize ignoring Coloring options (#186) Fix writer:: Summarize ignoring Coloring options (#186) Dec 13, 2021
@tyranron tyranron removed the bug Something isn't working label Dec 13, 2021
@tyranron tyranron merged commit 58dd096 into main Dec 13, 2021
@tyranron tyranron deleted the 186-fix-summarized-coloring branch December 13, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

Summary doesn't respect --color=never
2 participants
@ilslv @tyranron