Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight regex capture groups in terminal output (#42) #136

Merged
merged 41 commits into from
Oct 14, 2021
Merged

Highlight regex capture groups in terminal output (#42) #136

merged 41 commits into from
Oct 14, 2021

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Oct 1, 2021 •
edited by tyranron
Loading

Resolves #42

Synopsis

For now there is no way to tell from output, what capture groups were involved.

Solution

Highlight regex capture groups.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv
Add Features book chapter [skip ci]
06dae5d
@ilslv
Fill Test Modules Organization book chapter
00b861f
@ilslv
Revert README.md to link instead of trying to embed script
ca1a596
@ilslv
Corrections
1d9114d
@ilslv
Implement writer::Repeat
4a901b6
@ilslv
Update asciinema recordings
20a0afa
@ilslv
Mention writer::Repeat in the book
11f4712
@ilslv
Merge branch 'main' into output-only-skipped-or-failed
37d1235 
# Conflicts:
#	CHANGELOG.md
#	book/src/Features.md
#	book/src/Test_Modules_Organization.md
#	src/lib.rs
#	src/writer/basic.rs
@ilslv
Propagate errors encountered during Scenario Outline expansion
675e4be
@ilslv
Update asciinema in docs
9b77f4a
@ilslv
Corrections
d318077
@ilslv
Output tables in writer::Basic
a25cca2
@ilslv
Corrections
aadcd85
@ilslv
Revert "Output tables in writer::Basic"
7c12f0d 
This reverts commit a25cca2.
@ilslv
Expand Scenario Outline Examples in tables too
8c85eab
@ilslv
Fix CHANGELOG
f3c2db2
@ilslv
Mention Scenario Outline Examples expansion in Step Table in feature:…
6e37a99 
…:Ext::expand_examples()
@ilslv
WIP [skip ci]
47a6393
@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Oct 1, 2021
@ilslv ilslv added this to the 0.11 milestone Oct 1, 2021
@ilslv ilslv self-assigned this Oct 1, 2021
ilslv and others added 12 commits October 4, 2021 15:16
@ilslv
Merge branch 'main' into output-table-in-basic-writer
740a36f 
# Conflicts:
#	Cargo.toml
#	book/src/Getting_Started.md
#	src/cucumber.rs
#	src/event.rs
#	src/feature.rs
#	src/parser/basic.rs
#	src/parser/mod.rs
#	src/writer/basic.rs
#	src/writer/mod.rs
#	src/writer/repeat.rs
@ilslv
Fix CHANGELOG error
d8ac943
@tyranron
Some corrections [skip ci]
7eabf1d
@ilslv
Corrections
de57a3d
@ilslv
Merge branch 'output-table-in-basic-writer' into return-old-cli
8427dcf 
# Conflicts:
#	src/cucumber.rs
@ilslv
Corrections
84ce319
@ilslv
Corrections
09daa46
@ilslv
Merge branch 'return-old-cli' into highlight-step-captues
411a1f8 
# Conflicts:
#	book/src/Getting_Started.md
#	src/cucumber.rs
#	src/event.rs
#	src/writer/basic.rs
@ilslv
Corrections
6034f20
@ilslv
Merge branch 'main' into highlight-step-captues
c649031 
# Conflicts:
#	src/writer/basic.rs
#	tests/features/output/scenario_outline_table.feature.out
@ilslv
Merge branch 'main' into highlight-step-captues
1e997a3 
# Conflicts:
#	src/cli.rs
#	src/cucumber.rs
#	src/lib.rs
@ilslv
Corrections
cb4b3b7
@ilslv
Copy link
Member Author

ilslv commented Oct 14, 2021 •
edited by tyranron
Loading

FCM

Highlight regex capture groups in `writer::Basic` (#136, #42)

@ilslv ilslv requested a review from tyranron October 14, 2021 07:19
tyranron
tyranron approved these changes Oct 14, 2021
View reviewed changes
src/runner/basic.rs Outdated Show resolved Hide resolved
src/runner/basic.rs Outdated Show resolved Hide resolved
@tyranron tyranron modified the milestones: 0.11, 0.10 Oct 14, 2021
@tyranron tyranron changed the title Draft: Highlight regex capture groups in terminal output (#42) Highlight regex capture groups in terminal output (#42) Oct 14, 2021
@tyranron tyranron marked this pull request as ready for review October 14, 2021 08:56
@tyranron tyranron merged commit 9dbfe43 into main Oct 14, 2021
@tyranron tyranron deleted the highlight-step-captues branch October 14, 2021 09:03
@tyranron tyranron mentioned this pull request Oct 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.

Feature: Highlight regex capture groups in terminal output
2 participants
@ilslv @tyranron