Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins-stylelint/no-at-nest-rule #997

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Jun 4, 2023

A Stylelint plugin to change nested css with @nest to css without.
Effectively migrating to the latest specification.

I am not going to bother supporting the non-standard nesting that Chrome and Safari shipped.
i.e. I am not going to wrap stuff with :is().

The most important thing for us is that our users stop using @nest.


@Antonio-Laguna We discussed at some point that we would also create a monorepo for the Stylelint plugins under @csstools. I think this is still worthwhile but separate from this change.

If any Stylelint plugins are created in this repo they should be tightly coupled to a PostCSS plugin.

Let me know if you disagree :)

@github-actions github-actions bot added the e2e label Jun 4, 2023
@@ -147,6 +147,11 @@ export const osiApprovedWithCCO = [
];

const licenseExceptions = [
{
// because ... irony? 🤷
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romainmenke I agree completely!

I like how nice the tests are.
Does this need any special handling from the release script?

@romainmenke
Copy link
Member Author

I like how nice the tests are.
Does this need any special handling from the release script?

I ran the dry run thingy and that indicated that it would just work.
If I recall correctly I made the release script fairly agnostic of package contents. Because it are all workspaces under the same root it should just work 🤞

@romainmenke romainmenke merged commit 5eda268 into main Jun 13, 2023
@romainmenke romainmenke deleted the plugins-stylelint/no-at-nest-rule--empathetic-zebra-shark-a8b34dabd3 branch June 13, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants