Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export names from global class or id #21

Merged
merged 4 commits into from
Feb 26, 2020
Merged

Export names from global class or id #21

merged 4 commits into from
Feb 26, 2020

Conversation

david-zw-liu
Copy link
Contributor

Hi,
I made this change to export global class name or id name.
Because our project used css-loader with local mode without hash before.
Now I want to switch mode to global mode and keep using styles.className to reference class name in imported styles.

Please help checking whether this PR hurts any backwards compatibility.

Thanks.

Related issue:
webpack-contrib/css-loader#258

alexander-akait
alexander-akait requested changes Feb 25, 2020
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! We need an option for that, because enable that by default is a breaking change, i think good name for that is exportGlobals

@david-zw-liu
Copy link
Contributor Author

Good job! We need an option for that, because enable that by default is a breaking change, i think good name for that is exportGlobals

Hi @evilebottnawi ,
I just added exportGlobals option.
Could you please help review this again?

Thanks.

alexander-akait
alexander-akait approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @jquense

jquense
jquense approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@jquense jquense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me, seems like a reasonable option to be able to opt into

@alexander-akait alexander-akait merged commit 4ecc5d6 into css-modules:master Feb 26, 2020
@alexander-akait alexander-akait mentioned this pull request Feb 26, 2020
Closed
@david-zw-liu david-zw-liu mentioned this pull request Mar 17, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquense jquense jquense approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-zw-liu @jquense @alexander-akait