Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ocdav spaces aware #2396

Merged
merged 82 commits into from
Jan 4, 2022
Merged

Ocdav spaces aware #2396

merged 82 commits into from
Jan 4, 2022

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Dec 21, 2021 •
edited
Loading

PoC that uses ListStorageSaces to discover and aggregate PROPFINDS.

AFAICT having the path logic in the handler is way cleaner and reduces the amount of comlexity I have to be aware of in my head significantly, because the ocdav legacy endpoints always receive absolute paths. They can now always send relative paths. Far less if els statements. I'm not saying it is becoming easy ... but I can already make out some cleaner logic.

cc @aduffeck @kobergj

@butonic
allow sending path filter on ListStorageSpaces call
90ada7d 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
make sharesstorageprovider filter by nodeid
423bbe4 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
ocdax + spaces: introduce and refactor lookUpStorageSpacesForPath
c8cffd1 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
make propfind spaces aware, still flaky, infinite depth commented for…
9578017 
… now

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@update-docs
Copy link

update-docs bot commented Dec 21, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic requested a review from kobergj December 21, 2021 23:11
@butonic butonic self-assigned this Dec 21, 2021
butonic and others added 22 commits December 21, 2021 23:27
@butonic
add changelog
05b28b7 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
split lookup into two dedicated functions
7f6dff3 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
make delete spaces aware
ae0d10f 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
use explicit grant and mountpoint types
212f134 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
make ref debuggable
ec44216 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
make dav get spaces aware
244f9c2
fix requested path check
e493bab
@butonic
refactor spaces handler to use mountpoint
a7d1600 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
make head spaces aware
1036295
make mkcol spaces aware
61eb582
make move spaces aware
54e7291
make put spaces aware
64fbd84
make proppatch spaces aware
a7c3e43
@butonic
fix move: use dedicated intermediate resource
cc566a6 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
make copy spaces aware
ec33754
fix propfind for subfolders and subspaces
9857ad9
@butonic
add FIXMEs when using absolute references without an ID
88fb894 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
update config
f2d0170 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
fix propfind for subfolders
805515b
change copy reference to spaces reference
f7db547
@kobergj
remove node via os instead tree when create fails
89cc577 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
fix unit tests
a090e77 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
kobergj and others added 14 commits January 4, 2022 12:20
@kobergj
add userid to unittest mock
16fe66d 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@butonic
work on etag propagation
d00b14f 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
fix mostRecentChild logic
da6d24a 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
add missing license header
ab4bdc5 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
fix webdav spaces put and get
54efef6
fix spaces webdav endpoints
b777dcb 
I removed the namespace from the spaces handlers again because the
namespace depends on the respective space.
@butonic
drop unnecessary GetPath call in public file PROPFIND
6276681 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
fix webdav spaces propfind href
debb3b2
@butonic
fix on public file propfind/get/head
4a61864 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
fix makeRelativeReference
b1c9428 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
fix non existing rootinfo
a6ef42e 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
fix makeRelativeReference for spaces webdav
4197719
@butonic
use relative path when copying
8b21de2 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@kobergj
use source when listing while copying
7cb3906 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@butonic butonic marked this pull request as ready for review January 4, 2022 17:26
@butonic butonic merged commit 649b6a7 into cs3org:edge Jan 4, 2022
@butonic butonic deleted the ocdav-spaces-aware branch January 4, 2022 20:05
@micbar micbar mentioned this pull request Feb 16, 2022
Closed
22 tasks
@micbar micbar mentioned this pull request Mar 3, 2022
Closed
26 tasks
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@labkode labkode Awaiting requested review from labkode labkode is a code owner

Assignees

@butonic butonic

Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@butonic @kobergj